Date: Wed, 3 Feb 2021 19:23:42 +1100 From: Peter Jeremy <peter@rulingia.com> To: Alex Richardson <arichardson@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 83c20b8a2da0 - main - tests/sys/kern/crc32: Check for SSE4.2 before using it Message-ID: <YBpdjszbkJT5/V0q@server.rulingia.com> In-Reply-To: <202102021008.112A8RkU069892@gitrepo.freebsd.org> References: <202102021008.112A8RkU069892@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--9d7QdlvvMF1rOrGM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2021-Feb-02 10:08:27 +0000, Alex Richardson <arichardson@FreeBSD.org> wr= ote: >The branch main has been updated by arichardson: > >URL: https://cgit.FreeBSD.org/src/commit/?id=3D83c20b8a2da04937cf4af127366= b3dc92c855784 =2E.. > Differential Revision: https://reviews.freebsd.org/D28395 >--- =2E.. >diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile >index 1806d7ce8597..f350b740b7ea 100644 >--- a/tests/sys/kern/Makefile >+++ b/tests/sys/kern/Makefile >@@ -56,15 +56,15 @@ NETBSD_ATF_TESTS_C+=3D sysv_test > CFLAGS.mqueue_test+=3D -I${SRCTOP}/tests > LIBADD.mqueue_test+=3D rt >=20 >-.if ${MACHINE_ARCH} =3D=3D "amd64" || \ >- ${MACHINE_ARCH} =3D=3D "i386" || \ >- ${MACHINE_CPUARCH} =3D=3D "aarch64" > ATF_TESTS_C+=3D libkern_crc32 >+SRCS.libkern_crc32+=3D libkern_crc32.c >+.PATH: ${SRCTOP}/sys/libkern >+SRCS.libkern_crc32+=3D gsb_crc32.c >+CFLAGS.libkern_crc32+=3D -DTESTING > .if ${MACHINE_ARCH} =3D=3D "amd64" || ${MACHINE_ARCH} =3D=3D "i386" >-LDADD.libkern_crc32+=3D ${SRCTOP}/sys/libkern/x86/crc32_sse42.c >-.else >-LDADD.libkern_crc32+=3D ${SRCTOP}/sys/libkern/arm64/crc32c_armv8.S >-.endif >+SRCS.libkern_crc32+=3D ${SRCTOP}/sys/libkern/x86/crc32_sse42.c >+.elif ${MACHINE_CPUARCH} =3D=3D "aarch64" >+SRCS.libkern_crc32+=3D ${SRCTOP}/sys/libkern/arm64/crc32c_armv8.S > .endif >=20 > # subr_unit.c contains functions whose prototypes lie in headers that can= not be This breaks buildworld with a RO /usr/src for me: =2E.. =3D=3D=3D> tests/sys/kern (all) =2E.. Building /usr/obj/usr/src/arm64.aarch64/tests/sys/kern/pdeathsig (cd /usr/src/tests/sys/kern && DEPENDFILE=3D.depend.libkern_crc32 NO_SUBD= IR=3D1 make -f /usr/src/tests/sys/kern/Makefile _RECURSING_PROGS=3Dt PROG= =3Dlibkern_crc32 ) Building /usr/src/sys/libkern/arm64/crc32c_armv8.o clang -cc1as: error: unable to open output file '/usr/src/sys/libkern/arm64= /crc32c_armv8.o': 'Read-only file system' *** Error code 1 I do have an (empty) /usr/obj/usr/src/arm64.aarch64/tests/sys/kern/usr/src/sys/libkern/arm64 --=20 Peter Jeremy --9d7QdlvvMF1rOrGM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE7rKYbDBnHnTmXCJ+FqWXoOSiCzQFAmAaXYZfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEVF QjI5ODZDMzA2NzFFNzRFNjVDMjI3RTE2QTU5N0EwRTRBMjBCMzQACgkQFqWXoOSi CzQfXw//bIZtk9dOl7Mq4sUZ6qbcnkAowDfLQyr8qU4M6Y3lbivV+ZE3uJNLJt7s O7SWXPstmJeu5QN9OCnsWtMg2x/iJvMEmjCRNlxcgeQgkBcorx2oIpoNFlmM5jPP 3v7ymUMxK1/pDa5rMFA3zYOXm0UAqVawHi7qTmnM/ndGu+NOKij1xmHZvFpiTrgD tYLiJoS+/WR0Ql/7PF/3MOtJdqxcQut/uw4ftWxnbimnMGnPnl0sd0EZMpNj/Y40 4nhCVUVBDAPa4nQukytH0wGDjuw9svV5htxOSgdO5ZyuG10XnzxIn1iKzBByVS4d o5xJFt9ksPpdipsLM3lEQBXT+xcEA9r5tRLq8A1sC9B1QR6gi1SiNaa/UjWHDCp/ E/B9ulDneeWFnsdb8IEA/E7+yiI57K9K5CqpczgG9stOEJVbjhwE+sljWYI+MguM bRyjv299uiR6kA7vyAB6YsJucX52q26H9+2YjRDj+BkBSxSPqyRDnqQ18O9h/8+v MXe5vcM4Rkf2WK5nOvcpsYJ9Dxv7sT5Hz0LLpb3osqXu/I3jzVXTIEjvx3UN0bQl V+dpvQvbazbprm9IH4u4wn20yHyfHb4fpfyS7EIEHqVs3KveYxpeCgLuEt4z31hY y/maCXB1Ec8R40K3K+6fM9j/DqLHbaWK8jAyZmxQJe2nbVldYeI= =CNUM -----END PGP SIGNATURE----- --9d7QdlvvMF1rOrGM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YBpdjszbkJT5/V0q>