Date: Sat, 31 Aug 2013 15:00:24 +0200 From: Baptiste Daroussin <bapt@FreeBSD.org> To: Boris Samorodov <bsam@passap.ru> Cc: Guido Falsi <madpilot@FreeBSD.org>, FreeBSD ports list <freebsd-ports@FreeBSD.org>, Peter Wemm <peter@wemm.org> Subject: Re: svn commit: r325668 - head/x11-toolkits/open-motif Message-ID: <20130831130024.GZ12101@ithaqua.etoilebsd.net> In-Reply-To: <5221CEB4.7090109@passap.ru> References: <201308300952.r7U9qKsF026518@svn.freebsd.org> <52206DF8.1000401@FreeBSD.org> <5221CEB4.7090109@passap.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--4YatIo8qwOC8yTX3 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Aug 31, 2013 at 03:08:36PM +0400, Boris Samorodov wrote: > (moving the discussion to ports@) >=20 > 30.08.2013 14:03, Guido Falsi =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >=20 > > On 08/30/13 11:52, Boris Samorodov wrote: > >> Author: bsam > >> Date: Fri Aug 30 09:52:20 2013 > >> New Revision: 325668 > >> URL: http://svnweb.freebsd.org/changeset/ports/325668 > >> > >> Log: > >> Fix build at 10.x after recent changes at /usr/bin/ld. Error log: > >> ---- > >> ./../lib/Xm/.libs/libXm.so: undefined reference to `libiconv' > >> ./../lib/Xm/.libs/libXm.so: undefined reference to `libiconv_close' > >> ./../lib/Xm/.libs/libXm.so: undefined reference to `libiconv_open' > >> ----- > >> > >> PR: ports/181579 > >> Submitted by: bsam (me) > >> Approved by: Mikhail Tsatsenko <m.tsatsenko@gmail.com> (maintainer) > >> > >> Modified: > >> head/x11-toolkits/open-motif/Makefile > >> > >> Modified: head/x11-toolkits/open-motif/Makefile > >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > >> --- head/x11-toolkits/open-motif/Makefile Fri Aug 30 08:19:28 2013 (r3= 25667) > >> +++ head/x11-toolkits/open-motif/Makefile Fri Aug 30 09:52:20 2013 (r3= 25668) > >> @@ -30,6 +30,7 @@ GNU_CONFIGURE=3D yes > >> USE_LDCONFIG=3D yes > >> MAKE_ENV=3D LANG=3DC > >> CPPFLAGS+=3D -DCSRG_BASED -DXUSE_MTSAFE_API -DXNO_MTSAFE_PWDAPI -I${= PREFIX}/include > >> +LDFLAGS+=3D -L${PREFIX}/lib -liconv > >> USE_CSTD=3D gnu89 > >> > >> DEMOS_SRC=3D ${WRKSRC}/demos/programs > >=20 > > I'm having a lot of failures too related to libiconv symbols. These see= m=20 > > related by enabling iconv in libc on latest current. > >=20 > > I'm not sure that forcing them to link against gnu libiconv is a good= =20 > > long term solution. >=20 > Agreed. But this commit is not a log term solution. It's just a fix > which: > . preservs current status-quo (the port always depended upon libiconv); > . allow other ports which require this one to be build. >=20 > Thus it's just a bandaid. >=20 > > I think that making them work with just the libc=20 > > iconv implementation is a better solution, even if a little harder. It > > would allow us to not depend anymore on the libiconv port too. >=20 > I agree with a long term solution but we _need_ ports to work now. > So some of us patch the current tree, while others work on > infrastructure changes. >=20 > > I'm experimenting with making Uses/iconv.mk a noop for current where=20 > > libc includes iconv functions and making other ports compile using=20 > > system provided iconv. It looks doable, most ports need just trivial fi= xes. > > > > I was planning to ask an exp-run for this as soon as I am happy with my= =20 > > findings. >=20 > If your changes may hit the portstree in a couple of days then it's OK > to wait. But if it takes longer, then broken ports should be patched > (like at this commit). And then please do whatever you think is needed. > BTW, one of those victims has almost 500(!) dependent ports: > http://pb2.nyi.freebsd.org/bulk/nogcc-default/2013-08-30_22h26m46s/ >=20 This last build with with libc++ activated by default, it has fallout from = both iconv in libc and and libc++. regards, Bapt --4YatIo8qwOC8yTX3 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlIh6OgACgkQ8kTtMUmk6ExgXACgvvjj5kfm8Y9mSFEOE0t8elAi kvoAnRI//g/4vaRd3ov01o/cfPcO0rik =V/GF -----END PGP SIGNATURE----- --4YatIo8qwOC8yTX3--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130831130024.GZ12101>