Date: Tue, 22 May 2012 02:11:13 GMT From: Steve Wills <swills@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/168208: [PATCH] Fix DEPENDS assignment to use := Message-ID: <201205220211.q4M2BDgH095630@red.freebsd.org> Resent-Message-ID: <201205220220.q4M2K37m020724@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 168208 >Category: ports >Synopsis: [PATCH] Fix DEPENDS assignment to use := >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 22 02:20:03 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Steve Wills >Release: >Organization: >Environment: >Description: Ports that set their BUILD_DEPENDS equal to RUN_DEPENDS or vice versa should use the := construct to ensure that the values of the right hand side is expanded before being used. This helps ensure that parts of Mk/* that use the left hand side can do so safely. This is documented in portlint and has been a warning there for a while. Here's a patch which corrects all currently existing instances where := is not used. It will probably be quickly out of date, but these can be easily grep'd. The reason for wanting to solve this now is that the ports testing framework that I have been working on (see PR ports/164896) has a case where it needs to assign the RUN_DEPENDS to the TEST_DEPENDS and cases where the := isn't used cause a dependency loop. Figured we might as well solve this now. >How-To-Repeat: >Fix: See http://people.freebsd.org/~swills/depends_fixups.patch.txt (patch was too big to attach to PR) >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205220211.q4M2BDgH095630>