Date: Fri, 26 Apr 2019 13:07:59 +1000 From: Kubilay Kocak <koobs@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r500030 - in head/textproc/py-transifex-client: . files Message-ID: <fbb01ff1-e27a-bf36-a303-d245670103b0@FreeBSD.org> In-Reply-To: <20190425163322.tger5ynv6dvde5e4@ogg.in.absolight.net> References: <201904251618.x3PGIbqE013686@repo.freebsd.org> <20190425163322.tger5ynv6dvde5e4@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26/04/2019 2:33 am, Mathieu Arnold wrote: > Writing the versions requirements in the dependencies is probably more > effective than in a comment: > > On Thu, Apr 25, 2019 at 04:18:37PM +0000, Kubilay Kocak wrote: >> +RUN_DEPENDS= ${PYTHON_PKGNAMEPREFIX}urllib3>0:net/py-urllib3@${PY_FLAVOR} # <1.25 > > ${PYTHON_PKGNAMEPREFIX}urllib3>0<1.25:net/py-urllib3@${PY_FLAVOR} > > Even better written as: > > ${PYTHON_PKGNAMEPREFIX}urllib3<1.25:net/py-urllib3@${PY_FLAVOR} Mistake, will sort out > >> +RUN_DEPENDS+= ${PYTHON_PKGNAMEPREFIX}requests>=2.19.1:www/py-requests@${PY_FLAVOR} # <3.0.0 > > ${PYTHON_PKGNAMEPREFIX}requests>=2.19.1<3:www/py-requests@${PY_FLAVOR} >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?fbb01ff1-e27a-bf36-a303-d245670103b0>