Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 28 Oct 2008 02:15:17 +0000 (UTC)
From:      Kip Macy <kmacy@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-user@freebsd.org
Subject:   svn commit: r184384 - user/kmacy/HEAD_fast_xmit/sys/net
Message-ID:  <200810280215.m9S2FHM3063483@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kmacy
Date: Tue Oct 28 02:15:17 2008
New Revision: 184384
URL: http://svn.freebsd.org/changeset/base/184384

Log:
  Initialize ro.ro_rt to avoid confusing rtalloc
  don't call RT_UNLOCK(ro.ro_rt) - the rtalloc routine returns it unlocked

Modified:
  user/kmacy/HEAD_fast_xmit/sys/net/flowtable.c

Modified: user/kmacy/HEAD_fast_xmit/sys/net/flowtable.c
==============================================================================
--- user/kmacy/HEAD_fast_xmit/sys/net/flowtable.c	Tue Oct 28 01:21:19 2008	(r184383)
+++ user/kmacy/HEAD_fast_xmit/sys/net/flowtable.c	Tue Oct 28 02:15:17 2008	(r184384)
@@ -567,7 +567,8 @@ flowtable_lookup(struct flowtable *ft, s
 	u_char desten[ETHER_ADDR_LEN];
 
 	flags = ft ? ft->ft_flags : 0;
-
+	ro.ro_rt = NULL;
+	
 	/*
 	 * The internal hash lookup is the only IPv4 specific bit
 	 * remaining
@@ -624,7 +625,6 @@ uncached:
 	if (ro.ro_rt == NULL) 
 		error = ENETUNREACH;
 	else {
-		RT_UNLOCK(ro.ro_rt);
 		error = arpresolve(ro.ro_rt->rt_ifp, ro.ro_rt, m,
 		    &ro.ro_dst, desten);
 		route_to_rtentry_info(&ro, error ? NULL : desten, ri);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810280215.m9S2FHM3063483>