Date: Sun, 31 Mar 2019 23:45:42 +1100 From: Kubilay Kocak <koobs@FreeBSD.org> To: Jonathan Chen <jonc@chen.org.nz>, freebsd-ports@freebsd.org Subject: Re: Need a committer for textproc/sigil update Message-ID: <379bed74-049f-c076-72ed-2cab00b8745b@FreeBSD.org> In-Reply-To: <CAJuc1zNhU_Xr02-RP-Jgcrp=kYu5iwoLuwQCDJ8diTZ=ViF35Q@mail.gmail.com> References: <CAJuc1zNhU_Xr02-RP-Jgcrp=kYu5iwoLuwQCDJ8diTZ=ViF35Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 31/03/2019 8:21 pm, Jonathan Chen wrote: > Hi, > > Could a committer please take a look at: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236766 > > It got picked up by swills@ a few days ago, and it appears to have > stalled. I'm unsure as to whether it's with me or the assignee. > > Cheers. > Hi Jonathan, It can take time once assigned to be committed. Periods of a few days to a week or so are not uncommon. Steve usually picks up several/many issues he plans on working on in bulk, and commits them once they've been through review/QA. Contributors can help by ensuring they've already run their changes through QA (portlint, poudriere at least), and confirming that they have passed, in their submission. Something like the following is good: portlint: OK (looks fine.) testport: OK (poudriere: <versions>, <archs>, <OPTIONS> tested) maketest: OK (XXX of YYY tests PASS) If it takes longer than a couple of weeks, we can reset assignment based on an 'assignee timeout'. If there is no explicit request for feedback/additional changes, which people can request by setting maintainer-feedback to ? <your-email>, then it's not with you. ./koobs
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?379bed74-049f-c076-72ed-2cab00b8745b>