Date: Mon, 11 Dec 2000 15:59:54 -0800 From: Mike Smith <msmith@freebsd.org> To: Stefan Esser <se@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: PCI power states (was Re: fxp driver not reset after Windows reboot? ) Message-ID: <200012112359.eBBNxs301035@mass.osd.bsdi.com> In-Reply-To: Your message of "Mon, 11 Dec 2000 22:51:27 %2B0100." <20001211225127.B73017@StefanEsser.FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> > pci_enable_busmaster(dev);
> > pci_enable_io(dev, SYS_RES_IOPORT | SYS_RES_MEMORY);
> > pci_set_powerstate(dev, PCI_POWERSTATE_D0);
> >
> > Consider the above a request for review on the matter.
>
> Shouldn't that be:
>
> pci_enable_io(dev, SYS_RES_IOPORT | SYS_RES_MEMORY);
> pci_set_powerstate(dev, PCI_POWERSTATE_D0);
> device_specific_init(dev);
> pci_enable_busmaster(dev);
In terms of ordering? Yes, definitely,and thanks for pointing it out.
--
... every activity meets with opposition, everyone who acts has his
rivals and unfortunately opponents also. But not because people want
to be opponents, rather because the tasks and relationships force
people to take different points of view. [Dr. Fritz Todt]
V I C T O R Y N O T V E N G E A N C E
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200012112359.eBBNxs301035>