Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jul 2018 22:28:06 +0000 (UTC)
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        doc-committers@freebsd.org, svn-doc-all@freebsd.org, svn-doc-head@freebsd.org
Subject:   svn commit: r51986 - head/en_US.ISO8859-1/books/porters-handbook/special
Message-ID:  <201807102228.w6AMS6Z0050720@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mat
Date: Tue Jul 10 22:28:06 2018
New Revision: 51986
URL: https://svnweb.freebsd.org/changeset/doc/51986

Log:
  Add a note about MAKE_JOBS_UNSAFE and the importance to not why it is set.
  
  Sponsored by:	Absolight

Modified:
  head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml

Modified: head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml
==============================================================================
--- head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml	Tue Jul 10 08:38:43 2018	(r51985)
+++ head/en_US.ISO8859-1/books/porters-handbook/special/chapter.xml	Tue Jul 10 22:28:06 2018	(r51986)
@@ -514,6 +514,16 @@ IGNORE=	may not be redistributed because of licensing 
 	<literal>MAKE_JOBS_UNSAFE=yes</literal> variable.  It is
 	used when a port is known to be broken with
 	<varname>-jX</varname>.</para>
+
+      <important>
+	<para>When setting <varname>MAKE_JOBS_UNSAFE</varname>, it
+	  is very important to explain either with a comment in the
+	  <filename>Makefile</filename>, or at least in the commit
+	  message, <emphasis>why</emphasis> the port does not build
+	  when enabling.  Otherwise, it is almost impossible to
+	  either fix the problem, or test if it has been fixed when
+	  committing an update at a later date.</para>
+      </important>
     </sect2>
 
     <sect2 xml:id="using-make">



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201807102228.w6AMS6Z0050720>