Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Oct 2016 22:57:41 +0000 (UTC)
From:      "Stephen J. Kiernan" <stevek@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r307540 - head/sys/amd64/amd64
Message-ID:  <201610172257.u9HMvfdH068913@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: stevek
Date: Mon Oct 17 22:57:41 2016
New Revision: 307540
URL: https://svnweb.freebsd.org/changeset/base/307540

Log:
  Add sysctl to make amd64 minidump retry count tunable at runtime.
  
  PR:		213462
  Submitted by:	RaviPrakash Darbha <rdarbha@juniper.net>
  Reviewed by:	cemi, markj
  Approved by:	sjg (mentor)
  Obtained from:	Juniper Networks
  Differential Revision:	https://reviews.freebsd.org/D8254

Modified:
  head/sys/amd64/amd64/minidump_machdep.c

Modified: head/sys/amd64/amd64/minidump_machdep.c
==============================================================================
--- head/sys/amd64/amd64/minidump_machdep.c	Mon Oct 17 22:48:29 2016	(r307539)
+++ head/sys/amd64/amd64/minidump_machdep.c	Mon Oct 17 22:57:41 2016	(r307540)
@@ -37,6 +37,7 @@ __FBSDID("$FreeBSD$");
 #include <sys/kernel.h>
 #include <sys/kerneldump.h>
 #include <sys/msgbuf.h>
+#include <sys/sysctl.h>
 #include <sys/watchdog.h>
 #include <vm/vm.h>
 #include <vm/vm_param.h>
@@ -68,6 +69,9 @@ static void *dump_va;
 static size_t counter, progress, dumpsize;
 
 CTASSERT(sizeof(*vm_page_dump) == 8);
+static int dump_retry_count = 5;
+SYSCTL_INT(_machdep, OID_AUTO, dump_retry_count, CTLFLAG_RWTUN,
+    &dump_retry_count, 0, "Number of times dump has to retry before bailing out");
 
 static int
 is_dumpable(vm_paddr_t pa)
@@ -447,7 +451,7 @@ minidumpsys(struct dumperinfo *di)
 	printf("\n");
 	if (error == ENOSPC) {
 		printf("Dump map grown while dumping. ");
-		if (retry_count < 5) {
+		if (retry_count < dump_retry_count) {
 			printf("Retrying...\n");
 			goto retry;
 		}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201610172257.u9HMvfdH068913>