Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Aug 2008 08:43:14 -0700
From:      Adam Weinberger <adamw@FreeBSD.org>
To:        Ion-Mihai Tetcu <itetcu@FreeBSD.org>
Cc:        cvs-ports@FreeBSD.org, Adam Weinberger <adamw@FreeBSD.org>, Mark Linimon <linimon@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/games Makefile ports/games/secretmaryochronicles-music          Makefile distinfo pkg-descr pkg-plist
Message-ID:  <20080806154314.GB53713@toxic.magnesium.net>
In-Reply-To: <20080806092257.5c09cfd2@it.buh.tecnik93.com>
References:  <200808060337.m763b4lu014095@repoman.freebsd.org> <20080806091940.057a391c@it.buh.tecnik93.com> <20080806092257.5c09cfd2@it.buh.tecnik93.com>

next in thread | previous in thread | raw e-mail | index | archive | help
>> (08.05.2008 @ 2322 PST): Ion-Mihai Tetcu said, in 1.2K: <<
> On Wed, 6 Aug 2008 09:19:40 +0300
> QA Tindy <itetcu@FreeBSD.org> wrote:
> 
>  [ .. ]
> 
> > ===>  Installing for secretmaryochronicles-music-4.0
> > ===>   secretmaryochronicles-music-4.0 depends on executable: smc - found
> > ===>   Generating temporary packing list
> > ===>  Checking if games/secretmaryochronicles-music already installed    
> make: cannot open Makefile.
> *** Error code 2
> 
> It happens because you have do-install target inside .if !defined(NOPORTDOCS)
>> end of "Re: cvs commit: ports/games Makefile ports/games/secretmaryochronicles-music          Makefile distinfo pkg-descr pkg-plist" from Ion-Mihai Tetcu <<

I don't know why putting the do-install: target inside a block that is
only executed under specific conditions, leaving those with NOPORTDOCS
defined with no do-install: target whatsoever, would be a problem... but
I've changed it anyway to make you happy.

I *knew* I was gonna get a tinderbox barf for this port, but I figured
it'd be a plist issue, not a head-up-my-ass error. Thank you for
catching the problem, and thank you many more times for having the
solution too!

# Adam


--

Adam Weinberger
adamw@magnesium.net || adamw@vectors.cx
http://www.vectors.cx



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080806154314.GB53713>