Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Mar 2020 22:01:36 +0000 (UTC)
From:      Konstantin Belousov <kib@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r359470 - head/sys/kern
Message-ID:  <202003302201.02UM1aYp039769@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: kib
Date: Mon Mar 30 22:01:36 2020
New Revision: 359470
URL: https://svnweb.freebsd.org/changeset/base/359470

Log:
  kern_sendfile.c: do not release sfio reference on error.
  
  It is already done by sendfile_iodone(), now consistently for all errors.
  This de-facto reverts r358597, after r359466.
  
  Reviewed by:	glebius, markj
  Tested by:	pho
  Sponsored by:	The FreeBSD Foundation
  MFC after:	1 week
  Differential revision:	https://reviews.freebsd.org/D24038

Modified:
  head/sys/kern/kern_sendfile.c

Modified: head/sys/kern/kern_sendfile.c
==============================================================================
--- head/sys/kern/kern_sendfile.c	Mon Mar 30 21:57:28 2020	(r359469)
+++ head/sys/kern/kern_sendfile.c	Mon Mar 30 22:01:36 2020	(r359470)
@@ -469,7 +469,6 @@ sendfile_swapin(vm_object_t obj, struct sf_io *sfio, i
 				    __func__, pa, j));
 				vm_page_unwire(pa[j], PQ_INACTIVE);
 			}
-			refcount_release(&sfio->nios);
 			return (EIO);
 		}
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202003302201.02UM1aYp039769>