Date: Sun, 7 Oct 2012 09:14:13 -0700 From: Marcel Moolenaar <marcel@xcllnt.net> To: Garrett Cooper <yanegomi@gmail.com> Cc: Max Khon <fjoe@freebsd.org>, freebsd-bugs@freebsd.org, Marcel Moolenaar <marcel@freebsd.org>, "Simon J. Gerraty" <sjg@NetBSD.org> Subject: Re: misc/172440: [patch] [build] fix broken CTFCONVERT_CMD call Message-ID: <F5ADC56B-A7B9-4E0B-9869-AEB75C47D558@xcllnt.net> In-Reply-To: <CAGH67wR9P_QzR0Wd8EUd5EQ0xuLqVssGjsmZNEt%2B-7iiL1DGXg@mail.gmail.com> References: <201210070701.q977170a033550@red.freebsd.org> <201210070710.q977A9p8087371@freefall.freebsd.org> <CAGH67wR9P_QzR0Wd8EUd5EQ0xuLqVssGjsmZNEt%2B-7iiL1DGXg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 7, 2012, at 1:48 AM, Garrett Cooper <yanegomi@gmail.com> wrote: > <fix-MAKE_VERSION-nul-CTFCONVERT_CMD-check.patch.txt> Please don't use WITH_BMAKE. It's only added for handling the switch. The option will be removed soon. BTW: Isn't it easier to introduce a CC_CMD variable that contains at least the compile command and to which you can append any commands you want? Not only does that eliminate the problem at hand, it also makes the whole think a lot less like a one-off hack, and more like a fundamental feature. Other things we may want to do after we compile a file is generate API/ABI information that we can validate so that we can fail the build when some code change breaks the ABI or API. Thoughts? -- Marcel Moolenaar marcel@xcllnt.net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F5ADC56B-A7B9-4E0B-9869-AEB75C47D558>