Date: Sun, 5 Nov 2017 14:31:37 -0800 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r325368 - head/sys/kern Message-ID: <a01dc741-c202-d193-240d-9b9e163ffad7@FreeBSD.org> In-Reply-To: <1509908174.99235.60.camel@freebsd.org> References: <201711031921.vA3JLakQ010001@repo.freebsd.org> <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org> <CAPyFy2D0c6GQvrfE9CAx99Pj%2BF5QU_y%2BB6rpOY3BCPSFNDA5mA@mail.gmail.com> <1509908174.99235.60.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc Content-Type: multipart/mixed; boundary="1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Ian Lepore <ian@freebsd.org>, Ed Maste <emaste@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Message-ID: <a01dc741-c202-d193-240d-9b9e163ffad7@FreeBSD.org> Subject: Re: svn commit: r325368 - head/sys/kern References: <201711031921.vA3JLakQ010001@repo.freebsd.org> <15dc8575-c699-1101-c846-b4fbdef3d1d1@FreeBSD.org> <CAPyFy2D0c6GQvrfE9CAx99Pj+F5QU_y+B6rpOY3BCPSFNDA5mA@mail.gmail.com> <1509908174.99235.60.camel@freebsd.org> In-Reply-To: <1509908174.99235.60.camel@freebsd.org> --1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 11/5/2017 10:56 AM, Ian Lepore wrote: > On Fri, 2017-11-03 at 17:22 -0400, Ed Maste wrote: >> "On 3 November 2017 at 16:42, Bryan Drewery <bdrewery@freebsd.org> >> wrote: >>> >>> >>>> >>>> =C2=A0 Differential Revision:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0D12= 929 >>> Apparently this format closes the review now? I thought we needed a >>> full >>> URL? >> Interesting, Phabricator reports "We found a "Differential Revision" >> field with value "12929" in the commit message, and the domain on the >> URI matches this install, so we linked this commit to D12929."=C2=A0=C2= =A0It >> looks like Phabricator was changed to accept only the D##### tag, but >> not the "Explain why" text. >> >=20 > I like having the full URL, and would like that to remain the standard.= > =C2=A0It's very useful when you're perusing svn logs and you can just c= lick > on the url to get to the phab material cited in the commit. Yeah despite my "\o/", I ended up sticking to the URL format myself too. >=20 > If people want the convenience of typing the shorter info, could we > make the svn commit hooks expand it to an url? >=20 > -- Ian >=20 --=20 Regards, Bryan Drewery --1ao93I0CubWAXmQhDMKN9xbHgMgL5pbDa-- --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZ/5FJAAoJEDXXcbtuRpfPjUsIAMtN6sew8eA4bZFCJ1KQU1UM qRjI4Z6mPZjZ4Jt6etFekxYf2JSjyx2yO1mYDJgmhNjVztiJ4ofqNJNMUbO5FZ43 VJ/yb6lq0TRG4zJS381WvM+H6QeSMYcM9LCUe/2DDvVLs7vd7hQ7s9pC+eTu4uPw Clt6g3H7raSwS64vYox2LmKhJdYWiIg7OPdT1akOKemuC7riS7kPggwfa8U4V1DG oh7tNMt0pfxAl6YPhWs5/6APtv7cB3SxPabfdNiW4fpxcZIdrfatesJ237iUtTfk 14Us7lTtNqU2dCJlvXNE4MhmrBZOPN0yUr74RxGKzDkbd2FaS0mmvwTel5tqpLY= =GNr+ -----END PGP SIGNATURE----- --eKVbtsC7EcdvgcJCMVdgvuP3whRvnGfcc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a01dc741-c202-d193-240d-9b9e163ffad7>