Date: Sat, 04 Oct 2014 05:02:08 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-net@FreeBSD.org Subject: [Bug 193053] ixgbe(4) IXGBE_LEGACY_TX + ALTQ path broken Message-ID: <bug-193053-2472-a29kKNxzWK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-193053-2472@https.bugs.freebsd.org/bugzilla/> References: <bug-193053-2472@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=193053 --- Comment #12 from Dan <dan_256@yahoo.com> --- (In reply to ncrogers from comment #11) > (In reply to Dan from comment #10) > > On 10.1-RC1, with the change below, I still get the dreaded "pfctl: igb1: > > driver does not support altq". If ixgbe is targeted for 10.1-RELEASE, can > > igb be fixed as well? > > > > Index: sys/modules/igb/Makefile > > =================================================================== > > --- sys/modules/igb/Makefile (revision 272488) > > +++ sys/modules/igb/Makefile (working copy) > > @@ -21,7 +21,7 @@ > > # instead use the older if_start non-multiqueue capable interface. > > # This might be desireable for testing, or to enable the use of > > # ALTQ. > > -#CFLAGS += -DIGB_LEGACY_TX > > +CFLAGS += -DIGB_LEGACY_TX > > > > .if !defined(KERNBUILDDIR) > > .if ${MK_INET_SUPPORT} != "no" > > > > I posted more about it here: > > > > https://forums.freebsd.org/viewtopic.php?f=44&t=48283 > > I've always had to add #define IXGBE_LEGACY_TX to sys/dev/e1000/if_igb.c and > sys/dev/e1000/if_igb.h to get it to work. Uncommenting CFLAGS in the igb > Makefile doesn't work when compiling a kernel. I believe it needs to be > added as a kernel option of some kind to be cleaner. I guess in the last 3 years, no one has bother to do it because they keep secretly hoping we can stop using legacy mode to use ALTQ :) Pretty sure it would be easy to add as a kernel option. I even saw a thread where someone described what it would take. I wonder why it never got committed. -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-193053-2472-a29kKNxzWK>