Date: Thu, 29 Jan 2015 10:51:36 +0000 From: "kostikbel (Konstantin Belousov)" <phabric-noreply@FreeBSD.org> To: freebsd-net@freebsd.org Subject: [Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: <bf5fbf22867d0427321493098e40cfa5@localhost.localdomain> In-Reply-To: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org> References: <differential-rev-PHID-DREV-vhk6ww63dvpj6egspuyt-req@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
kostikbel added a subscriber: kostikbel. kostikbel added a comment. Also would be nice to further split the patch into the mechanical change of the cc_exec/cc_migration macros, and the real fix(es). From what I read, the patch is correct, but it is currently noisy, which makes reading harder and less convincing. What about previous Hans' patch ? Is this one a replacement, i.e. is it believed that the same bugs are fixed there without rewriting and without modifying the callout KPI ? INLINE COMMENTS sys/conf/files:3006 The kern_testfrwk.c should be optional, with the possibility to be built as module. I do support the request to split the patch into the callout fix proper and everything else. REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, adrian, sbruno, lstewart, imp, hselasky Cc: kostikbel, emaste, delphij, neel, erj, freebsd-net
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bf5fbf22867d0427321493098e40cfa5>