Date: Sat, 21 Jan 2017 02:43:10 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 195763] bsdgrep, empty matches and -o Message-ID: <bug-195763-8-uyan2VmiNQ@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-195763-8@https.bugs.freebsd.org/bugzilla/> References: <bug-195763-8@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D195763 Kyle Evans <bsdports@kyle-evans.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179126|0 |1 is obsolete| | --- Comment #3 from Kyle Evans <bsdports@kyle-evans.net> --- Created attachment 179171 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D179171&action= =3Dedit Proposed patch to address line matching issues emaste@ - I believe this to be my final iteration of this patch. Because th= is and bug #209116 are both somewhat major issues with procline(), this patch addresses both PRs and obsoletes both previous patches. I've added to printline() a bail-out if -o and matchall (empty pattern) are= set -- this coincides with GNU grep's behavior. Assuming I ran the tests correctly (make && make install && kyua test -k /usr/tests/usr.bin/grep/Kyuafile), I haven't yet introduced any regressions there. One of my next steps might be to review the unit test coverage and m= ake sure it's sufficient, though, since it was passing before despite having all kinds of problems. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-195763-8-uyan2VmiNQ>