Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 20 Nov 2006 19:38:43 +0100
From:      Erwin Lansing <erwin@FreeBSD.org>
To:        ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, scrappy@FreeBSD.org
Subject:   Re: cvs commit: ports/www Makefile
Message-ID:  <20061120183843.GO69151@droso.net>
In-Reply-To: <200611201827.kAKIRIA0034030@repoman.freebsd.org>
References:  <200611201827.kAKIRIA0034030@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Mk3/ZKr+/6W72LQ3
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Marc,

I really can't believe you committed this, there are so many things
wrong with this port, I don't know where to start. You just added an
*exact* copy of an existing port with some added patches in files/ and
called it exactly the same name. The way you forked this port, should
have been done by a repocopy as well, but it's too late for that now.
I am not quite sure what you are trying to achieve with this new port,
but it looks like this could be integrated with the existing
mod_log_sql2 port with OPTIONS or alternatively the new port has to be
redone completely as a slave port.

In future, please don't hesitate to ask if you are unsure of how to do
something.

-erwin

On Mon, Nov 20, 2006 at 06:27:18PM +0000, Erwin Lansing wrote:
> erwin       2006-11-20 18:27:18 UTC
>=20
>   FreeBSD ports repository
>=20
>   Modified files:
>     www                  Makefile=20
>   Log:
>   Disconnect mod_log_sql2-dtc from the build to fix INDEX.
>  =20
>   Hat:            portmgr
>  =20
>   Revision  Changes    Path
>   1.1608    +1 -1      ports/www/Makefile
>=20
> http://cvsweb.FreeBSD.org/ports/www/Makefile.diff?r1=3D1.1607&r2=3D1.1608=
&f=3Dh
> | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> | RCS file: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v
> | retrieving revision 1.1607
> | retrieving revision 1.1608
> | diff -u -p -r1.1607 -r1.1608
> | --- ports/www/Makefile	2006/11/20 06:13:45	1.1607
> | +++ ports/www/Makefile	2006/11/20 18:27:18	1.1608
> | @@ -1,4 +1,4 @@
> | -# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v 1.1607=
 2006/11/20 06:13:45 scrappy Exp $
> | +# $FreeBSD: /usr/local/www/cvsroot/FreeBSD/ports/www/Makefile,v 1.1608=
 2006/11/20 18:27:18 erwin Exp $
> |  #
> | =20
> |      COMMENT =3D Ports related to the World Wide Web
> | @@ -361,7 +361,7 @@
> |      SUBDIR +=3D mod_log_spread
> |      SUBDIR +=3D mod_log_sql
> |      SUBDIR +=3D mod_log_sql2
> | -    SUBDIR +=3D mod_log_sql2-dtc
> | +#    SUBDIR +=3D mod_log_sql2-dtc
> |      SUBDIR +=3D mod_macro
> |      SUBDIR +=3D mod_macro2
> |      SUBDIR +=3D mod_mp3
--=20
Erwin Lansing                                     http://droso.org
Security is like an onion.          (o_ _o)
It's made up of several layers   \\\_\   /_///    erwin@FreeBSD.org
And it makes you cry.            <____) (____>    erwin@aauug.dk

--Mk3/ZKr+/6W72LQ3
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (FreeBSD)

iD8DBQFFYfYzqy9aWxUlaZARAvnOAJ46puoMVejshdJovigsEav2rJak2wCgoUqZ
NPyhsuMw/qJm9TJlhc8h1+0=
=iCOT
-----END PGP SIGNATURE-----

--Mk3/ZKr+/6W72LQ3--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20061120183843.GO69151>