Date: Mon, 5 Jan 2009 12:43:56 -0800 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: "Bjoern A. Zeeb" <bz@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Christoph Mallon <christoph.mallon@gmx.de>, src-committers@freebsd.org Subject: Re: svn commit: r186751 - in head/sys: netinet6 netipsec Message-ID: <20090105204356.GA52934@troutmask.apl.washington.edu> In-Reply-To: <20090105194210.P45399@maildrop.int.zabbadoz.net> References: <200901042153.n04LrgkD075147@svn.freebsd.org> <20090104220716.GL14235@hoeg.nl> <alpine.BSF.2.00.0901042213530.67103@fledge.watson.org> <20090105172400.T45399@maildrop.int.zabbadoz.net> <49624DB9.8080900@gmx.de> <20090105194210.P45399@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 05, 2009 at 07:45:47PM +0000, Bjoern A. Zeeb wrote: > On Mon, 5 Jan 2009, Christoph Mallon wrote: > > Hi, > > >Bjoern A. Zeeb schrieb: > >>I have broken it out from a larger patch; the C99 initializer is here: > >>http://people.freebsd.org/~bz/20090105-02-c99-initializers.diff > >> > >>I case someone can give it a quick glance I'll commit them. > > > >+ .pr_flags = PR_ATOMIC|PR_ADDR, > > > >style(9) wants spaces around binary operators. > > I am not sure it does. In case it does I am not going to break > consistency with all other 65 places that don't do for pr_flags; > but it seems I should change the <tab>=<space> to <space>=<tab>. > Thanks for making me look, and thanks for review! > >From style(9): Unary operators do not require spaces, binary operators do. and Stylistic changes (including whitespace changes) are hard on the source repository and are to be avoided without good reason. So, it appears your change conforms to the prevailing style of the file, and is acceptable. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090105204356.GA52934>