Date: Fri, 15 Feb 2019 12:32:03 -0700 From: Warner Losh <imp@bsdimp.com> To: Ian Lepore <ian@freebsd.org> Cc: Enji Cooper <yaneurabeya@gmail.com>, Eric Joyner <erj@freebsd.org>, Robert Huff <roberthuff@rcn.com>, FreeBSD Current <current@freebsd.org> Subject: Re: problem building dev/e1000 Message-ID: <CANCZdfqWBJU_JXtE==cVX-jiseDtbKSc4FjToArnhj7dQ_p68Q@mail.gmail.com> In-Reply-To: <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org> References: <23653.56460.521599.489556@jerusalem.litteratus.org> <754B5C21-656B-4A67-BA39-50BB4AF5C0CD@gmail.com> <CAKdFRZjdR0%2BMEFhApLcV5me8Nt=R7F1yOoW34owQYne-T9Ehmg@mail.gmail.com> <652F1541-52DE-4744-8AEA-8EE6434E04E8@gmail.com> <39629f6cb41cff32b348cf5d329d425352c28464.camel@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Feb 15, 2019 at 12:17 PM Ian Lepore <ian@freebsd.org> wrote: > On Fri, 2019-02-15 at 10:53 -0800, Enji Cooper wrote: > > > On Feb 15, 2019, at 10:46, Eric Joyner <erj@freebsd.org> wrote: > > > > > > ifdi_if.h is a system generated interface file that network drivers > > > that depend on iflib use. It's generated from ifdi_if.m in sys/net. > > > > > > My guess is that you don't have "device iflib" defined in your > > > kernel configuration. em(4) depends on iflib in FreeBSD 12/13, and > > > with r343617, iflib is now explicitly a module that needs to be > > > included in your kernel config if you want to use a driver that > > > depends on it. It's already in the GENERIC kernel for amd64; are > > > you using a kernel config file that doesn't inherit from GENERIC? > > > > HO Eric! > > > > iflib was a recently added requirement on stable/12 IIRC..? > > > > Does the manpage note this dependency, and is there an UPDATING entry > > for this change? > > > > Thanks! > > -Enji > > > > My question would be: why? If some drivers have a new dependency on > iflib, why isn't that expressed in sys/conf/files and handled > automatically? > Right now we have files:net/iflib.c optional ether pci iflib in the files file. This would need to change to files:net/iflib.c optional ether pci (em | igb | ...) but we don't have a () operator in config. Or we'd need dozens of lines, and the duplicate elimination code in config has been tricky (though I didn't check it just now). Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfqWBJU_JXtE==cVX-jiseDtbKSc4FjToArnhj7dQ_p68Q>