Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jan 2017 22:33:07 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r311175 - head/usr.sbin/bsnmpd/tools/bsnmptools
Message-ID:  <201701032233.v03MX7LJ034439@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Tue Jan  3 22:33:07 2017
New Revision: 311175
URL: https://svnweb.freebsd.org/changeset/base/311175

Log:
  Swap parameters around with parse_syntax_strval(..) for consistency with
  other parse_* APIs in bsnmp*
  
  MFC after:	3 days
  Noted by:	bz

Modified:
  head/usr.sbin/bsnmpd/tools/bsnmptools/bsnmpget.c

Modified: head/usr.sbin/bsnmpd/tools/bsnmptools/bsnmpget.c
==============================================================================
--- head/usr.sbin/bsnmpd/tools/bsnmptools/bsnmpget.c	Tue Jan  3 22:31:05 2017	(r311174)
+++ head/usr.sbin/bsnmpd/tools/bsnmptools/bsnmpget.c	Tue Jan  3 22:33:07 2017	(r311175)
@@ -849,10 +849,9 @@ parse_pair_numoid_val(char *str, struct 
 	return (1);
 }
 
-/* XXX-BZ aruments should be swapped. */
 static int32_t
-parse_syntax_strval(struct snmp_toolinfo *snmptoolctx, char *str,
-    struct snmp_object *object)
+parse_syntax_strval(struct snmp_toolinfo *snmptoolctx,
+    struct snmp_object *object, char *str)
 {
 	uint32_t len;
 	enum snmp_syntax syn;
@@ -924,7 +923,7 @@ parse_pair_stroid_val(struct snmp_toolin
 		return (-1);
 	}
 
-	if (parse_syntax_strval(snmptoolctx, ptr + 1, obj) < 0)
+	if (parse_syntax_strval(snmptoolctx, obj, ptr + 1) < 0)
 		return (-1);
 
 	return (1);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701032233.v03MX7LJ034439>