Date: Mon, 8 Jul 2002 08:48:48 -0700 From: Juli Mallett <jmallett@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/ps print.c Message-ID: <20020708084847.C39552@FreeBSD.ORG> In-Reply-To: <20020708121714.GF75407@starjuice.net>; from sheldonh@starjuice.net on Mon, Jul 08, 2002 at 02:17:14PM %2B0200 References: <200207072146.g67Lk0nT041098@freefall.freebsd.org> <20020708121714.GF75407@starjuice.net>
next in thread | previous in thread | raw e-mail | index | archive | help
* De: Sheldon Hearn <sheldonh@starjuice.net> [ Data: 2002-07-08 ] [ Subjecte: Re: cvs commit: src/bin/ps print.c ] > On (2002/07/07 14:45), Juli Mallett wrote: > > > Modified files: > > bin/ps print.c > > Log: > > Make printval() take a 'void *' thus negating any assumptions the compiler > > may try to make about the alignment of the dereferenced datum. > > Doesn't this break buildworld with warnings promoted to errors? Lack of downgrading of -Wformat does that, and this code relies on that breakage, and my changes had no effect on the code in question, in the manner in question. The commit that broke this was when I removed WFORMAT explicit setting because 'make WARNS=6' never gave me trouble, and such, and I forgot that WARNS doesnt imply WFORMAT. Oops. I'll back that part of it out. Thanks. > ===> bin/ps > [...] > cc -O -pipe -march=pentiumpro -DLAZY_PS -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wformat=2 -Wno-format-extra-args -Werror -c /usr/src/bin/ps/print.c > cc1: warnings being treated as errors > /usr/src/bin/ps/print.c: In function `started': > /usr/src/bin/ps/print.c:400: warning: `%y' yields only last 2 digits of year > /usr/src/bin/ps/print.c: In function `lstarted': > /usr/src/bin/ps/print.c:417: warning: `%c' yields only last 2 digits of year in some locales on non-BSD systems > /usr/src/bin/ps/print.c: In function `printval': > /usr/src/bin/ps/print.c:686: warning: format not a string literal, argument types not checked > /usr/src/bin/ps/print.c:689: warning: format not a string literal, argument types not checked > [...] > > Ciao, > Sheldon. -- Juli Mallett <jmallett@FreeBSD.org> | FreeBSD: The Power To Serve Will break world for fulltime employment. | finger jmallett@FreeBSD.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020708084847.C39552>