Date: 23 Jul 2001 14:17:13 +0200 From: Assar Westerlund <assar@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Warner Losh <imp@harmony.village.org>, Wes Peters <wes@softweyr.com>, Brian Somers <brian@Awfulhak.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/lib/libutil ecalloc.c emalloc.3 emalloc.c erealloc.c estrdup.c Makefile libutil.h Message-ID: <5lelr7x2k5.fsf@assaris.sics.se> In-Reply-To: Bruce Evans's message of "Mon, 23 Jul 2001 21:14:06 %2B1000 (EST)" References: <Pine.BSF.4.21.0107232048460.32891-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bruce Evans <bde@zeta.org.au> writes: > Yes, most exit() and err*() calls in libraries are bugs. Hm. lib/libutil/login_auth.c:auth_checknologin and there seems to be some more. > Other problems with this idea: > - the new functions don't belong in libutil for various reasons: > + libutil should not be a home for miscellaneous functions. > + shared linkage to another library is a pessimization (always in > time and perhaps in space too). Where do they belong? Having them in every program seems a pessimization too. > - these functions are often named xmalloc(), etc. (e.g., in gnu utilities). > Are you going to changes all these too? (Certainly not in contrib). I don't think we should modify contrib/* code to use such functions. > I noticed new copies of these functions growing faster than the initial > version of this change was reviewed. There is another set in rcorder. Yes. /assar To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5lelr7x2k5.fsf>