Date: Sun, 2 Mar 2008 10:08:42 +0300 From: Ruslan Ermilov <ru@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: Kris Kennaway <kris@FreeBSD.org>, Perforce Change Reviews <perforce@FreeBSD.org>, Kip Macy <kmacy@FreeBSD.org> Subject: Re: PERFORCE change 135010 for review Message-ID: <20080302070842.GA65621@team.vega.ru> In-Reply-To: <200802150952.39027.jhb@freebsd.org> References: <200802080420.m184Kvmf077416@repoman.freebsd.org> <200802141032.33861.jhb@freebsd.org> <47B4E0F1.6060006@FreeBSD.org> <200802150952.39027.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi John,
Your patch below looks good enough for committing.
On Fri, Feb 15, 2008 at 09:52:38AM -0500, John Baldwin wrote:
> Index: kmod.mk
> ===================================================================
> RCS file: /usr/cvs/src/sys/conf/kmod.mk,v
> retrieving revision 1.221
> diff -u -r1.221 kmod.mk
> --- kmod.mk 19 Nov 2007 16:24:10 -0000 1.221
> +++ kmod.mk 15 Feb 2008 14:50:03 -0000
> @@ -428,6 +428,9 @@
> assym.s: @/kern/genassym.sh
> .endif
> sh @/kern/genassym.sh genassym.o > ${.TARGET}
> +.if defined(KERNBUILDDIR)
> +genassym.o: opt_global.h
> +.endif
> .if exists(@)
> genassym.o: @/${MACHINE_ARCH}/${MACHINE_ARCH}/genassym.c
> .endif
> @@ -439,6 +442,10 @@
> lint: ${SRCS}
> ${LINT} ${LINTKERNFLAGS} ${CFLAGS:M-[DILU]*} ${.ALLSRC:M*.c}
>
> +.if defined(KERNBUILDDIR)
> +${OBJS}: opt_global.h
> +.endif
> +
> .include <bsd.dep.mk>
>
> cleandepend: cleanilinks
>
>
> BTW, reading kmod.mk the submit above only works if .depend doesn't exist. It
> won't work if you have run 'make depend' because of this:
>
> .if !exists(${.OBJDIR}/${DEPENDFILE})
> ${OBJS}: ${SRCS:M*.h}
> .endif
Cheers,
--
Ruslan Ermilov
ru@FreeBSD.org
FreeBSD committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080302070842.GA65621>