Date: Tue, 27 Oct 2020 16:42:49 +0000 From: Alexander Richardson <arichardson@freebsd.org> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: Hans Petter Selasky <hselasky@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r366993 - head/sys/net Message-ID: <CA%2BZ_v8r0yZsO6-=K4gt78mSjNekxvB4UAvHr78Y=GX3HnoWeag@mail.gmail.com> In-Reply-To: <20201024125206.GB38000@FreeBSD.org> References: <202010241023.09OANMcL075640@repo.freebsd.org> <20201024125206.GB38000@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 24 Oct 2020 at 13:52, Alexey Dokuchaev <danfe@freebsd.org> wrote: > > On Sat, Oct 24, 2020 at 10:23:22AM +0000, Hans Petter Selasky wrote: > > New Revision: 366993 > > URL: https://svnweb.freebsd.org/changeset/base/366993 > > > > Log: > > Run code through "clang-format -style=file" with some additional fixes. > > No functional change. > > > > ... > > @@ -99,8 +97,8 @@ infiniband_ipv4_multicast_map(uint32_t addr, > > > > #ifdef INET6 > > static inline void > > -infiniband_ipv6_multicast_map(const struct in6_addr *addr, > > - const uint8_t *broadcast, uint8_t *buf) > > +infiniband_ipv6_multicast_map( > > + const struct in6_addr *addr, const uint8_t *broadcast, uint8_t *buf) > > { > > This is not how we format these in FreeBSD, please revert. It was correct > before and no "fix" is need here. > > ./danfe Unfortunately this is a limitation of the current clang-format version. I've submitted a patch upstream as https://reviews.llvm.org/D90246 and the config file change is https://reviews.freebsd.org/D26978. Alex
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BZ_v8r0yZsO6-=K4gt78mSjNekxvB4UAvHr78Y=GX3HnoWeag>