Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 13 Apr 2000 16:19:32 -0700 (PDT)
From:      Kris Kennaway <kris@FreeBSD.org>
To:        Warner Losh <imp@village.org>
Cc:        "Jordan K. Hubbard" <jkh@zippy.cdrom.com>, Robin Melville <robmel@innotts.co.uk>, Doug Barton <Doug@gorean.org>, stable@FreeBSD.org
Subject:   Re: 4.0, OpenSSL and MD5 (fwd) 
Message-ID:  <Pine.BSF.4.21.0004131616150.45420-100000@freefall.freebsd.org>
In-Reply-To: <200004132314.RAA48943@harmony.village.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 13 Apr 2000, Warner Losh wrote:

> NO_FOO?=no
> 
> .if ${NO_FOO} != "no"
> 	do foo
> .endif
> 
> works quite well.  Where to put the NO_FOO?= line is harder to know,
> but certainly it is a solvable problem.  Maybe in a bsd.default.mk
> file, which is included early in the bsd.* files.

The problem comes when you have things like:

.if exists(${.CURDIR}/../../secure) && !defined(NOCRYPT) &&
!defined(NOSECURE) && !defined(NO_OPENSSL) && !defined(RELEASE_CRUNCH)

where it becomes an unreadable mess to test each of the options for their
values as well. I've simplified this kind of statement a lot by making
variables automatically imply their subsidiaries in Makefile.inc1, but the
more complicated the expression is the greater the chance of misreading it
(a lot of the ones we have now have missing/wrong clauses).

Kris

----
In God we Trust -- all others must submit an X.509 certificate.
    -- Charles Forsythe <forsythe@alum.mit.edu>



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0004131616150.45420-100000>