Date: Mon, 15 Jul 2002 15:16:43 +0400 (MSD) From: Dmitry Morozovsky <marck@rinet.ru> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/40593: www/oops FreeBSD port does not obey BATCH Message-ID: <200207151116.g6FBGhD50705@woozle.rinet.ru>
next in thread | raw e-mail | index | archive | help
>Number: 40593
>Category: ports
>Synopsis: www/oops FreeBSD port does not obey BATCH
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Jul 15 04:20:01 PDT 2002
>Closed-Date:
>Last-Modified:
>Originator: Dmitry Morozovsky
>Release: FreeBSD 4-STABLE i386
>Organization:
Cronyx Plus LLC (RiNet ISP)
>Environment:
System: FreeBSD 4-STABLE
>Description:
/usr/ports/www/oops does not obey BATCH building at create user phase.
Unfortunately, last maintainer has dropped maintainership.
>How-To-Repeat:
# at a system without 'oops' user
cd /usr ports/www/oops
make install BATCH=yes
>Fix:
This patch seems to be ugly even for me. ;-) Anyway, it works.
BTW, I don't know should PACKAGE_BUILDING also be checked.
Feel free to modify.
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/www/oops/Makefile,v
retrieving revision 1.16
diff -u -r1.16 Makefile
--- Makefile 30 May 2002 23:02:39 -0000 1.16
+++ Makefile 13 Jul 2002 01:12:54 -0000
@@ -44,7 +44,7 @@
.endif
pre-install:
- @PKG_PREFIX=${PREFIX} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
+ @PKG_PREFIX=${PREFIX} BATCH=${BATCH} ${SH} ${PKGINSTALL} ${PKGNAME} PRE-INSTALL
.include <bsd.port.pre.mk>
Index: pkg-install
===================================================================
RCS file: /home/ncvs/ports/www/oops/pkg-install,v
retrieving revision 1.2
diff -u -r1.2 pkg-install
--- pkg-install 15 Dec 2000 11:35:58 -0000 1.2
+++ pkg-install 13 Jul 2002 01:17:29 -0000
@@ -37,7 +37,13 @@
echo "You already have a user \"${user}\", so I will use it."
else
echo "You need a user \"${user}\"."
- if yesno "Would you like me to create it" y; then
+ doadduser=1
+ if [ "$BATCH" = "yes" ]; then
+ doadduser=0
+ else
+ yesno "Would you like me to create it" y && doadduser=0
+ fi
+ if [ $doadduser = 0 ]; then
/usr/sbin/pw useradd ${user} -g ${group} -h - -d /nonexistent \
-s /nonexistent -c "Oops Cache System" || exit
echo "Done."
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207151116.g6FBGhD50705>