Date: Tue, 22 May 2018 09:03:02 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 228418] www/tomcat85: drop start_precmd from tomcat85.in Message-ID: <bug-228418-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D228418 Bug ID: 228418 Summary: www/tomcat85: drop start_precmd from tomcat85.in Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: ports-bugs@FreeBSD.org Reporter: 1983-01-06@gmx.net CC: vvd@unislabs.com CC: vvd@unislabs.com Flags: maintainer-feedback?(vvd@unislabs.com) The start_precmd with the setenv.sh has no effect and shall be dropped for these reasons: 1. It has been designed to be sourced by catalina.sh, we aren't using it. We use jsvc (which could probably have been done with daemon(8)) 2. None of the variables are available to the jsvc process when started with service(8) verified with: > @Override > protected void doGet(HttpServletRequest req, HttpServletResponse resp) > throws ServletException, IOException { >=20 > PrintWriter w =3D resp.getWriter(); >=20 > for (Map.Entry<String, String> prop : System.getenv().entrySet()) { > w.print(prop.getKey()); > w.print(" =3D "); > w.println(prop.getValue()); > } >=20 > for (Map.Entry<Object, Object> prop : System.getProperties().entrySet())= { > w.print(prop.getKey()); > w.print(" =3D "); > w.println(prop.getValue()); > } >=20 > } For service(8) it must be exported first, this isn't required by catalina.sh and not documented by pkg-message. At best, the start_precmd is dropped altogether. Users can always use ${name}_env to pass vars. This works for me. This issue likely applies to all other Tomcat ports. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-228418-7788>