Date: Tue, 28 Feb 2006 16:38:53 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Mikhail Teterin <mi+mxe@aldan.algebra.com> Cc: ports@FreeBSD.org, gnome@FreeBSD.org, obrien@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: While we discuss libtool (-fpic vs. -fPIC) Message-ID: <20060228213853.GB87033@xor.obsecurity.org> In-Reply-To: <1141162512.20664.96.camel@mteterin.us.murex.com> References: <20060228192453.GA84695@xor.obsecurity.org> <1141155894.20664.59.camel@mteterin.us.murex.com> <20060228195014.GA85269@xor.obsecurity.org> <1141156556.20664.66.camel@mteterin.us.murex.com> <20060228201124.GA85491@xor.obsecurity.org> <1141158688.20664.82.camel@mteterin.us.murex.com> <20060228204406.GA86137@xor.obsecurity.org> <1141159754.20664.89.camel@mteterin.us.murex.com> <20060228213131.GB86137@xor.obsecurity.org> <1141162512.20664.96.camel@mteterin.us.murex.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--24zk1gE8NUlDmwG9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 28, 2006 at 04:35:12PM -0500, Mikhail Teterin wrote: > ? ??, 2006-02-28 ? 16:31 -0500, Kris Kennaway ????: > > In fact I'd say none will (except those that might break by having it > > defined unexpectedly), because any port that needs to define -DPIC > > that in order to conditionally compile PIC code must already be doing > > so, or it'd be broken out of the box. >=20 > Well being 100% correct is better, than being 99.99% correct. Yes, but: > As I said, > these things aren't worth the trouble of chasing individual ports, but > making something like libtool DTRT is a good idea. >=20 > This includes both, `-fpic' and `-DPIC' flags. As I argued, spamming in -DPIC everywhere with libtool is at best a NOP and at worst may break ports that expect it to be undefined for whatever reason. The defaults are fine.. Kris --24zk1gE8NUlDmwG9 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.1 (FreeBSD) iD8DBQFEBMLtWry0BWjoQKURAoJDAJ9rXwHP/QL0dzoIU/WuFmStliLBPgCgpqQC 8uL9g5IS3ufa1UGziwT+vWI= =ug23 -----END PGP SIGNATURE----- --24zk1gE8NUlDmwG9--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060228213853.GB87033>