Date: Mon, 15 Mar 2004 23:50:24 +1100 (EST) From: Edwin Groothuis <edwin@mavetju.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/64293: [patch] unbreak devel/ruby-rudl Message-ID: <20040315125024.7714C619E@k7.mavetju> Resent-Message-ID: <200403151300.i2FD0Fn4021151@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 64293
>Category: ports
>Synopsis: [patch] unbreak devel/ruby-rudl
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Mar 15 05:00:14 PST 2004
>Closed-Date:
>Last-Modified:
>Originator: Edwin Groothuis
>Release: FreeBSD 5.2.1-RELEASE i386
>Organization:
-
>Environment:
System: FreeBSD k7.mavetju 5.2.1-RELEASE FreeBSD 5.2.1-RELEASE #3: Fri Feb 27 13:54:29 EST 2004 edwin@k7.mavetju:/usr/src/sys/i386/compile/k7 i386
>Description:
See bento and friends:
http://portsmon.firepipe.net/portoverview.py?category=&portname=ruby-rudl
To make a long story short: the $CFLAGS in the extconf.rb needs an
extra space before adding the -Wall to it.
Also, when checking for SDL, check for SDL-1.1
>How-To-Repeat:
>Fix:
Either use this file as files/patch-extconf.rb:
--- extconf.rb.orig Wed May 16 03:55:22 2001
+++ extconf.rb Mon Mar 15 23:43:45 2004
@@ -8,7 +8,7 @@
windows=/mswin32|cygwin/ =~ RUBY_PLATFORM
-$CFLAGS+="-Wall "
+$CFLAGS+=" -Wall "
if !windows then
$CFLAGS += `#{sdl_config} --cflags`.chomp
@@ -24,8 +24,8 @@
have_header('SDL_image.h')
have_header('SDL_mixer.h')
-if have_library('SDL', 'SDL_Quit') and
- have_library('SDLmain') and
+if have_library('SDL-1.1', 'SDL_Quit') and
+ have_library('SDLmain-1.1') and
have_header('SDL.h') then
create_makefile('RUDL')
or this patch which is hard to understand what is going on in.
Index: files/patch-extconf.rb
===================================================================
RCS file: /home/pcvs/ports/devel/ruby-rudl/files/patch-extconf.rb,v
retrieving revision 1.3
diff -u -r1.3 patch-extconf.rb
--- files/patch-extconf.rb 15 May 2001 19:01:19 -0000 1.3
+++ files/patch-extconf.rb 15 Mar 2004 12:45:36 -0000
@@ -1,14 +1,22 @@
---- extconf.rb.orig Wed May 16 02:55:22 2001
-+++ extconf.rb Wed May 16 03:51:59 2001
-@@ -24,9 +24,7 @@
+--- extconf.rb.orig Wed May 16 03:55:22 2001
++++ extconf.rb Mon Mar 15 23:43:45 2004
+@@ -8,7 +8,7 @@
+
+ windows=/mswin32|cygwin/ =~ RUBY_PLATFORM
+
+-$CFLAGS+="-Wall "
++$CFLAGS+=" -Wall "
+
+ if !windows then
+ $CFLAGS += `#{sdl_config} --cflags`.chomp
+@@ -24,8 +24,8 @@
have_header('SDL_image.h')
have_header('SDL_mixer.h')
-if have_library('SDL', 'SDL_Quit') and
- have_library('SDLmain') and
-- have_header('SDL.h') then
--
-+if have_func('SDL_Quit') and
-+ have_header('SDL.h') then
++if have_library('SDL-1.1', 'SDL_Quit') and
++ have_library('SDLmain-1.1') and
+ have_header('SDL.h') then
+
create_makefile('RUDL')
- end
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040315125024.7714C619E>