Date: Tue, 6 May 2003 08:57:33 -0600 From: Greg Lewis <glewis@misty.eyesbeyond.com> To: Mario Sergio Fujikawa Ferreira <lioux@FreeBSD.org> Cc: ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/java/jdk13/files patch-iomgr.c Message-ID: <20030506145733.GA8070@misty.eyesbeyond.com> In-Reply-To: <20030506133458.2393.qmail@exxodus.fedaykin.here> References: <200305060611.h466B2io078265@repoman.freebsd.org> <20030506133458.2393.qmail@exxodus.fedaykin.here>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 06, 2003 at 10:34:36AM -0300, Mario Sergio Fujikawa Ferreira wrote: > On Mon, May 05, 2003 at 11:10:40PM -0700, Greg Lewis wrote: > > glewis 2003/05/05 23:11:02 PDT > > > > FreeBSD ports repository > > > > Added files: > > java/jdk13/files patch-iomgr.c > > Log: > > . Remove an assert() which asserts that if isatty() is true then > > ttyname() must not return NULL. This isn't entirely true according > > to the manual page (the device must be able to be found as well) and > > certainly appears to not necessarily be true in the package building > > environment on bento (plus at least the PR submitter's environment). > > > > Note that this assert() was, of course, only ever triggered when > > running in debug mode (which most people don't, but does happen > > during the build in some parts). Also note that there is a check > > for isatty() preceding the call for ttyname() and a NULL return > > from ttyname() is handled, so removing this assert should not > > create any problems. > > Shouldn't we bump PORTREVISION? Not for this commit (its only come up in very rare cases, and for those cases they wouldn't have been able to build). However, I should have bumped it for the Math.pow() fix. Thanks for the reminder :). -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030506145733.GA8070>