Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 24 Aug 1999 17:46:40 -0400 (EDT)
From:      Ryan <ryan@ryan.org>
To:        hackers@freebsd.org
Subject:   Are certain parts of kernel not using suser() when they should?
Message-ID:  <Pine.BSF.3.96.990824172943.3756A-100000@ryan.org>

next in thread | raw e-mail | index | archive | help
Grepping through the kernel source tree, one finds these 12 files that use
"uid == 0" checks instead of the usual suser(). There may be more than one
instance per function/macro:

./kern/kern_ktrace.c		- ktrops(), ktrcanset()
./nfs/nfs_subs.c 		- nfsrv_fhtoup()
./posix4/p1003_1b.c 		- CAN_AFFECT macro
./kern/kern_sig.c 		- CANSIGNAL, CANSIGIO macros
./kern/sysv_ipc.c 		- ipcperm()
./miscfs/devfs/devfs_vnops.c 	- devfs_setattr()

./isofs/cd9660/cd9660_vnops.c	- cd9660_access()
./miscfs/kernfs/kernfs_vnops.c 	- kernfs_access()
./miscfs/procfs/procfs_vnops.c 	- procfs_access()
./msdosfs/msdosfs_vnops.c 	- msdosfs_access()
./nfs/nfs_vnops.c 		- nfsspec_access(), nfs_access()
./ufs/ufs/ufs_vnops.c 		- ufs_access()

Is there a reason for these checks not to use suser?

-Ryan



To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.990824172943.3756A-100000>