Date: Mon, 30 Apr 2001 12:01:19 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Alfred Perlstein <bright@wintelcom.net> Cc: smp@FreeBSD.org, Jake Burkholder <jburkholder0829@home.com> Subject: Re: that vm diff now makes it into single user mode. Message-ID: <XFMail.010430120119.jhb@FreeBSD.org> In-Reply-To: <20010429013533.D18676@fw.wintelcom.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 29-Apr-01 Alfred Perlstein wrote: > * Jake Burkholder <jburkholder0829@home.com> [010428 23:10] wrote: >> >> i386/i386/vm_machdep.c: >> >> the mtx_trylock in vm_page_zero_idle is unnecessary, the lock is >> already held. This whole thing needs to be non-blocking if its >> going to be called from the idle loop, but I'm not sure that >> that's still possible. Its currently commented out. > > Ok, should be fixed. I guess we now know where it could have been > useful to be able to spin on a sleeplock, ie not worry about > idle getting stuck on a runqueue/sleepqueue. Having the idle process hold locks that other threads block on can really start wreaking havoc when you throw priority propagation into the mix. It would be best to push the page zeroing off into a very low priority kernel thread or something. -- John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010430120119.jhb>