Date: Mon, 30 Apr 2007 18:48:02 +0400 From: Andrey Chernov <ache@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh var.c Message-ID: <20070430144802.GA55665@nagual.pp.ru> In-Reply-To: <20070430.082645.270753761.imp@bsdimp.com> References: <200704301144.l3UBig50070087@repoman.freebsd.org> <20070430.082645.270753761.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 30, 2007 at 08:26:45AM -0600, M. Warner Losh wrote: > Andrey, > > Can you bump the __FreeBSD_version in sys/param.h for these changes > and document it in the FreeBSD committer's handbook? Yes, of course, but a bit later. Currently changes are in progress, preparing to putenv() rewriting. Unlike portable soft like gcc, cvs, etc. FreeBSD have a bad habbit considering putenv() arg as safe to pass and forget (because putenv() was incorrecly implemented via setenv(), which copy the arg), there still a lot of places to fix, almost every putenv() usage in FreeBSD is unportable... :( -- http://ache.pp.ru/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070430144802.GA55665>