Date: Wed, 20 Mar 2002 21:35:03 +0700 From: Eugene Grosbein <eugen@grosbein.pp.ru> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG, Kirk McKusick <mckusick@mckusick.com> Subject: Re: kern/35969: kernel option PPP_DEFLATE often procudes kernel panics; PPP_BSDCOMP sometimes procudes stalled connections Message-ID: <20020320213503.A344@grosbein.pp.ru>
next in thread | raw e-mail | index | archive | help
> Plese bring your tree back to the latest -stable and apply the > patch I include below, then tell me if it fixes your crashes. My dialin server is revived now. It works as expected. I thank Matthes Dillon, Kirk McKusic and other people of stable@freebsd.org for their help. It seems, that commit affected src/lib/libz/infblock.c and it's possible it still contatins the bug that is fixed now in the kernel. I talk about this: Index: infblock.c =================================================================== RCS file: /home/ncvs/src/lib/libz/infblock.c,v retrieving revision 1.1.1.4 retrieving revision 1.1.1.4.6.1 diff -u -r1.1.1.4 -r1.1.1.4.6.1 --- infblock.c 10 Jan 1999 09:46:55 -0000 1.1.1.4 +++ infblock.c 22 Feb 2002 02:48:40 -0000 1.1.1.4.6.1 @@ -3,6 +3,9 @@ * For conditions of distribution and use, see copyright notice in zlib.h */ +#include <sys/cdefs.h> +__FBSDID("$FreeBSD: src/lib/libz/infblock.c,v 1.1.1.4.6.1 2002/02/22 02:48:40 jedgar Exp $"); + #include "zutil.h" #include "infblock.h" #include "inftrees.h" @@ -249,10 +252,11 @@ &s->sub.trees.tb, s->hufts, z); if (t != Z_OK) { - ZFREE(z, s->sub.trees.blens); r = t; - if (r == Z_DATA_ERROR) + if (r == Z_DATA_ERROR) { + ZFREE(z, s->sub.trees.blens); s->mode = BAD; + } LEAVE } s->sub.trees.index = 0; @@ -313,11 +317,12 @@ t = inflate_trees_dynamic(257 + (t & 0x1f), 1 + ((t >> 5) & 0x1f), s->sub.trees.blens, &bl, &bd, &tl, &td, s->hufts, z); - ZFREE(z, s->sub.trees.blens); if (t != Z_OK) { - if (t == (uInt)Z_DATA_ERROR) + if (t == (uInt)Z_DATA_ERROR) { + ZFREE(z, s->sub.trees.blens); s->mode = BAD; + } r = t; LEAVE } @@ -329,6 +334,7 @@ } s->sub.decode.codes = c; } + ZFREE(z, s->sub.trees.blens); s->mode = CODES; case CODES: UPDATE Eugene Grosbein To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020320213503.A344>