Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 17 Jun 2013 09:23:52 +0000 (UTC)
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   svn commit: r321090 - head/multimedia/handbrake
Message-ID:  <201306170923.r5H9Nq5P013775@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: danfe
Date: Mon Jun 17 09:23:52 2013
New Revision: 321090
URL: http://svnweb.freebsd.org/changeset/ports/321090

Log:
  Handbrake tries to dlopen() libdvdcss.so.2, while library installed by the
  libdvdcss package is actually libdvdcss.so.3, so the call always fails and
  handbrake is unable to properly read CSS-encoded DVDs.
  
  Patch in the PR suggested bumping requested shlib version accordingly, but
  methinks it is better to just remove it completely from CSS_LIB definition.
  While here, register run-time dependency on `multimedia/libdvdcss'.
  
  PR:		ports/171473
  Submitted by:	Heath Nielson
  Approved by:	maintainer timeout (dmarion, over 9 months)

Modified:
  head/multimedia/handbrake/Makefile

Modified: head/multimedia/handbrake/Makefile
==============================================================================
--- head/multimedia/handbrake/Makefile	Mon Jun 17 08:39:52 2013	(r321089)
+++ head/multimedia/handbrake/Makefile	Mon Jun 17 09:23:52 2013	(r321090)
@@ -3,7 +3,7 @@
 
 PORTNAME=	handbrake
 PORTVERSION=	0.9.8
-PORTREVISION=	1
+PORTREVISION=	2
 CATEGORIES=	multimedia
 MASTER_SITES=	SF/${PORTNAME}/${PORTVERSION} \
 		http://download.handbrake.fr/handbrake/contrib/:contrib
@@ -38,6 +38,7 @@ LICENSE=	GPLv2
 
 BUILD_DEPENDS=	yasm:${PORTSDIR}/devel/yasm
 LIB_DEPENDS=	fribidi:${PORTSDIR}/converters/fribidi
+RUN_DEPENDS=	${LOCALBASE}/lib/libdvdcss.so:${PORTSDIR}/multimedia/libdvdcss
 
 USE_AUTOTOOLS=	libtool aclocal
 LIBTOOLFILES=	configure
@@ -125,6 +126,8 @@ post-patch:
 	@${REINPLACE_CMD} -e 's|/usr/local|${LOCALBASE}|' \
 		${WRKSRC}/contrib/libass/module.defs \
 		${WRKSRC}/libhb/module.defs ${WRKSRC}/test/module.defs
+	@${REINPLACE_CMD} -e 's|libdvdcss\.so\.2|libdvdcss.so|' \
+		${BUILD_WRKSRC}/contrib/libdvdread/libdvdread/src/dvd_input.c
 
 do-install:
 	${INSTALL_PROGRAM} ${BUILD_WRKSRC}/HandBrakeCLI ${PREFIX}/bin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201306170923.r5H9Nq5P013775>