Date: Fri, 30 Sep 2016 18:44:18 -0400 From: Alexander Kabaev <kabaev@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: Lewis Donzis <lew@perftech.com>, deischen@freebsd.org, freebsd-arch@freebsd.org Subject: Re: mq on kqueue broken after upgrade to FreeBSD 11 Message-ID: <20160930184418.1047afc2@kan> In-Reply-To: <20160930152006.GS38409@kib.kiev.ua> References: <8A6CD0D3-C4D5-40DF-B2AD-4C454CC88AD1@perftech.com> <20160930094544.GP38409@kib.kiev.ua> <19A6EEAA-C68E-4DAD-B98F-4D904734BD8B@perftech.com> <20160930152006.GS38409@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--Sig_/s1L.FtqcOpp=DJ7kemp/wKd Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 30 Sep 2016 18:20:06 +0300 Konstantin Belousov <kostikbel@gmail.com> wrote: > On Fri, Sep 30, 2016 at 06:52:52AM -0500, Lewis Donzis wrote: > > =20 > > > On Sep 30, 2016, at 4:45 AM, Konstantin Belousov > > > <kostikbel@gmail.com> wrote: Where was a discussion about the > > > function presence being the mistake ? =20 > >=20 > > I think it was here: > > https://lists.freebsd.org/pipermail/freebsd-current/2015-November/05870= 6.html > >=20 > > which was just about a year ago. Perhaps I???m reading it wrong, > > but it seems like the implication is that removing the symbol from > > being exported was a "fix", where DE says "Why do the tests in > > tests/sys/mqueue/ try to use non-public APIs?" and then later, > > "symbol versioning for librt was broken and leaking symbols that > > shouldn't have been leaked."=20 > I added Daniel to Cc:. I think that the issue you referenced is > somewhat different. The r291439 commit restored symbol versioning, > i.e. before it, all symbols were accessible. Right now we are > discussing the merits of making one symbol accessible, which was > removed from the export table as a side effect of the fix. In other > words, if at the time of r291439 the symbol was present in the public > export list, your code would not note the fix. >=20 > > =20 > > > In r291439, symbol versioning for librt was fixed, and apparently > > > __mq_oshandle() is not present in the global symbols list for > > > librt. I suspect that this is an erronous ommission, since the > > > function' declaration is present in the mqueue.h header and it is > > > used by some mqueue tests. > > >=20 > > > As such, I believe that exporting it is the intended option there. > > > The following patch should fix the problem for you. =20 > >=20 > > That makes sense, and appreciate the patch, but > > just to be clear, does your change get committed so that we won???t > > have to re-apply it after future updates/upgrades?=20 > As I stated, my opinion is that this symbol can be usefully exported. > Its name is in implementation-private namespace, and there are uses > where access to the mqueue fd (or to the timer id) gives more > flexibility and significantly reduces the amount of code. >=20 > Unless there appear strong objections against the export, I will > commit the patch, sure. No objection, but possible suggestion: if the primary use of this symbol is for tests and nothing else, maybe it does belong in FBSDprivate_1.0 FBSDprivate_1.0 section instead? --=20 Alexander Kabaev --Sig_/s1L.FtqcOpp=DJ7kemp/wKd Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJX7urCXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRDNUY3RDk5NTk5QjY0MUUxM0M1MTU2OTEw NzEzMjI5OTkyNzkyRTdFAAoJEAcTIpmSeS5+4NQQAKX/d0lsBL1q4H60eh8YUJBq 1XDDBYWivELNvskSbRYJS2/RC3a3jKmf4guNH1WHiDJ1FrqtrxpJtWKVR0fyPPu7 6u97aIR2neH3qeSHelVL7SMNmu0kGRwSvHApcdD+zF3xw+plfwJpXGyPK7vJ+2q7 y3k8NmBX/ccTnddNcpGCcnn2dI2pl7MuekdLNH3YbWjq4Iphu1PbjULVcXbc2ipb i5fjdc9ezxpZ75JHTYeW1e3l83Wkiv+01db7wfy51ILFpmyOwohufaK8WPFtq74B pebhVHO0wCh06WAjifp1bbIPwmV92Yg/nKe+AKjKXOmvXi/WUZFoA307KSNKEhSr C05aXmyagp615Bm/zDWvmv1dvRjjKZ2SVl1MV5xPySIxi7zPhXpQ+GF63KlSpBUN tgGbrvfAc5hBk0XKc7BI8u3AUzk0nQnWP73yF2yBX6eyi5L0xuBnVeN8zXEAOIGw VSAbH3pMk/rdd1SN3aVqxAuzScc7PqZSdnpBxY5F70TvL9yS3LeFB47+abqIH9Bm 1ZRD6s/bc51cGth3fDywJXuO5n3PX0+g8hbuuGp6M8M3e7dZelj92ql3Kybw0v1P pnhBHwyIBxatDlkJsVahWV59ZFwniwGmiv2RbQwlZ6cF2vLsYduEOTnFOTnCcQ6X jOrBYeZFn9kThjEpmC9g =mvK6 -----END PGP SIGNATURE----- --Sig_/s1L.FtqcOpp=DJ7kemp/wKd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160930184418.1047afc2>