Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 08 Sep 2014 00:05:40 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 181301] New port: net/kamailio - A very fast and configurable open source SIP proxy
Message-ID:  <bug-181301-13-YQdjUsNK5S@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-181301-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-181301-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=181301

--- Comment #7 from John Marino <marino@FreeBSD.org> ---
1) this has to be fixed:
WARN: Makefile: [92]: NOPORTDOCS found.  Consider using PORT_OPTIONS:MDOCS.

2) CFLAGS+=    -Wall -Werror
NEVER, NEVER, NEVER intentionally add -Werror.  We *REMOVE* that flag when we
see it

3) COMMENT=    A very fast and configurable open source SIP proxy
Never start a COMMENT with "A", "The", "An", or the name of the port

4) XWRKSRC=        ${WRKDIR}/${PORTNAME}-${PORTVERSION}
Why are you doing this?  That's the default value of WRKSRC

5) XPLIST_SUB+=    MYSQL=""
X.else
XPLIST_SUB+=    MYSQL="@comment "

This is ancient use of options, use the new OPTIONS_SUB please (review porters
handbook on OPTIONS)


Is that huge block for stripping really necessary?  Why isn't the vendor file
doing that?

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-181301-13-YQdjUsNK5S>