Date: Tue, 22 Jul 2003 19:16:22 +0000 From: Bosko Milekic <bmilekic@technokratis.com> To: Poul-Henning Kamp <phk@phk.freebsd.dk> Cc: Marcel Moolenaar <marcel@xcllnt.net> Subject: Re: cvs commit: src/sys/kern init_main.c kern_malloc.c md5c.c subr_autoconf.c subr_mbuf.c subr_prf.c tty_subr.c vfs_cluster.c vfs_subr.c Message-ID: <20030722191622.GA61992@technokratis.com> In-Reply-To: <16119.1058914594@critter.freebsd.dk> References: <3F1DBD05.A4886D5E@imimic.com> <16119.1058914594@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 23, 2003 at 12:56:34AM +0200, Poul-Henning Kamp wrote: ... > I agree that there are exceptional cases, I agree that we need some > sort of __inline_damnit, but I still request that we only used it when > we know for a fact that there is an actual benefit. > > And the only two criteria I think are trivial to use for proving an > actual benefit is: > 1. less code is generated. > 2. it runs faster in tests. > > I am very reluctant to accept "a speculated benefit" when there is > as strong a counter indication as 2k extra code segment. What about the example I (and Bruce) posted in the other thread? That example does not necessarily meet your criteria but it certainly is valid as it minimizes code duplication and does not necessarily impact badly on performance (think of a case where the tradeoff between having it as a function call or inlined in a couple of places is evened out). > -- > Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 > phk@FreeBSD.ORG | TCP/IP since RFC 956 > FreeBSD committer | BSD since 4.3-tahoe > Never attribute to malice what can adequately be explained by incompetence. -- Bosko Milekic * bmilekic@technokratis.com * bmilekic@FreeBSD.org TECHNOkRATIS Consulting Services * http://www.technokratis.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030722191622.GA61992>