Date: Tue, 05 Dec 2000 10:54:26 +0200 From: Maxim Sobolev <sobomax@FreeBSD.org> To: mharo@FreeBSD.org Cc: Akinori MUSHA <knu@iDaemons.org>, FreeBSD-ports <freebsd-ports@FreeBSD.org> Subject: Re: portlint update Message-ID: <3A2CAD41.39793C0A@FreeBSD.org> References: <86u28kwghs.wl@archon.local.idaemons.org> <3A2B895D.D67E403A@FreeBSD.org> <86sno4w5g6.wl@archon.local.idaemons.org> <3A2BBF80.9CC69A1E@FreeBSD.org> <20001204104216.A44022@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Michael Haro wrote: > On Mon, Dec 04, 2000 at 06:00:00PM +0200, Maxim Sobolev wrote: > > > Maybe it would be better to add MASTER_SITES_ALL variable into bsd.sites.mk, which will contain all MASTER_SITE_*? Then it could be easily > > dumped with make -V MASTER_SITES_ALL, thus eliminating the need for parsing bsd.sites.mk directly. > > > > -Maxim > > > > With a MASTER_SITES_ALL variable portlint wouldn't be able to recommend > a fix, just detect a problem. > > I think parsing bsd.sites.mk is probably better. Huh, it seems that I did not properly describe my proposal. What I'm proposing is to add new variable, say MASTER_SITES_ALL, which will contain *names* of individual MASTER_SITE_* variables, i.e. MASTER_SITES_ALL= MASTER_SITE_FOO MASTER_SITE_BAR ... Then portlint will be able to get names of those variables by quering make -V MASTER_SITES_ALL and query each indivudual variable using make -V ... . This should help in situation, when some of MASTER_SITE_* defined as a superset of some other MASTER_SITE_* (for example currently MASTER_SITE_XFREE and several other defined based on MASTER_SITE_RINGSERVER). -Maxim To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A2CAD41.39793C0A>