Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 30 Nov 2005 09:20:27 +0000 (GMT)
From:      Robert Watson <rwatson@FreeBSD.org>
To:        John Baldwin <jhb@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/kern uipc_socket.c
Message-ID:  <20051130091930.K95395@fledge.watson.org>
In-Reply-To: <200511292307.jATN7EJH055853@repoman.freebsd.org>
References:  <200511292307.jATN7EJH055853@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On Tue, 29 Nov 2005, John Baldwin wrote:

>  Fix snderr() to not leak the socket buffer lock if an error occurs in
>  sosend().  Robert accidentally changed the snderr() macro to jump to the
>  out label which assumes the lock is already released rather than the
>  release label which drops the lock in his previous change to sosend().
>  This should fix the recent panics about returning from write(2) with the
>  socket lock held and the most recent LOR on current@.

Thanks for fixing this -- I ran this patch in testing for ages, but must 
have done some "clean up" or other such 99.85% harmless activity :-(.

Robert N M Watson



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051130091930.K95395>