Date: Tue, 25 Nov 2008 11:26:59 -0600 (CST) From: "Sean C. Farley" <scf@FreeBSD.org> To: =?ISO-8859-15?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r185237 - head/lib/libutil Message-ID: <alpine.BSF.2.00.0811251125220.3927@thor.farley.org> In-Reply-To: <86wsetfd36.fsf@ds4.des.no> References: <200811232326.mANNQCLp067323@svn.freebsd.org> <86wsetfd36.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --56599777-309033472-1227634019=:3927 Content-Type: TEXT/PLAIN; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Mon, 24 Nov 2008, Dag-Erling Smørgrav wrote: > Sean Farley <scf@FreeBSD.org> writes: >> Log: >> Fixed style issues with variable ordering and naming, spacing and >> parentheses. >> >> Fixed alignment issue in gr_dup() in its assignment of gr_mem using a >> struct to force alignment without performing alignment mathematics. This >> was noticed recently with libutil was built with WARNS=6 on platform such >> as sparc64. >> >> Added checks to gr_dup(), gr_equal() and gr_make() to prevent segfaults >> when examining struct group's with the struct members pointing to NULL's. >> >> With fix of alignment issue, restore WARNS?=6. > > Good work, thank you! You are welcome. Thank you too for the help on the alignment issue and plethora of style questions. :) Sean -- scf@FreeBSD.org --56599777-309033472-1227634019=:3927--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0811251125220.3927>