Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 26 Apr 2021 15:31:51 +0000
From:      Alexey Dokuchaev <danfe@freebsd.org>
To:        Kubilay Kocak <koobs@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: 44b57221ced8 - main - Update OpenBVE to version 1.8.0.2.
Message-ID:  <YIbc5w6ZG2BVRENY@FreeBSD.org>
In-Reply-To: <79b8acd0-ea24-c5e7-82db-a6a4ab768a10@FreeBSD.org>
References:  <202104261107.13QB7wDs039231@gitrepo.freebsd.org> <79b8acd0-ea24-c5e7-82db-a6a4ab768a10@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 26, 2021 at 09:28:42PM +1000, Kubilay Kocak wrote:
> On 26/04/2021 9:07 pm, Alexey Dokuchaev wrote:
> > ...
> > commit 44b57221ced803c65ed137d495fb787537915ee6
> > ...
> >      Update OpenBVE to version 1.8.0.2.
> 
> Any chance of getting cat/port: as prefixes to ports commit titles?

Admittedly, I find this format quite hard to read: every time I catch
an exception, have to skip the first foo/bar part to get to what goes
after, and only if it was not clear (or important to know) what is the
port it was about, go back to the beginning.  Note that I did mention
the port name in the first line, but in a way that does not disrupt
the reading flow.

I'm also worried that this is needless duplication: this information
can be inferred from the commit itself:

$ git show --pretty="" --name-only 44b5722 | xargs dirname | sort | uniq
games/openbve
games/openbve/files

People have asked for it because there is no path in the the subject
line with the default git email template.  Wouldn't it be better to
fix this rather than keep duplicating port directory in every commit?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YIbc5w6ZG2BVRENY>