Date: Mon, 10 Mar 2008 17:00:06 GMT From: John Baldwin <jhb@FreeBSD.org> To: freebsd-acpi@FreeBSD.org Subject: Re: kern/121504: [patch] Correctly set hw.acpi.osname on certain machines Message-ID: <200803101700.m2AH06RT026748@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/121504; it has been noted by GNATS.
From: John Baldwin <jhb@FreeBSD.org>
To: bug-followup@FreeBSD.org, amistry@am-productions.biz
Cc: njl@FreeBSD.org
Subject: Re: kern/121504: [patch] Correctly set hw.acpi.osname on certain machines
Date: Mon, 10 Mar 2008 12:20:49 -0400
This is not the correct patch. The _OSI method does not return an OS name
like _OS. Instead, it is a function that returns a boolean (True/False) to
say if a given OS name is supported (OS name is passed as an argument). The
proper fix is to say that the osname is supported in the
AcpiOsValidateInterface() method. Something like this should work:
Index: Osd/OsdMemory.c
===================================================================
RCS file: /usr/cvs/src/sys/dev/acpica/Osd/OsdMemory.c,v
retrieving revision 1.15
diff -u -r1.15 OsdMemory.c
--- Osd/OsdMemory.c 22 Mar 2007 18:16:41 -0000 1.15
+++ Osd/OsdMemory.c 10 Mar 2008 16:20:03 -0000
@@ -77,6 +77,9 @@
ACPI_STATUS
AcpiOsValidateInterface (char *Interface)
{
+
+ if (strcmp(Interface, acpi_osname) == 0)
+ return (AE_OK);
return (AE_SUPPORT);
}
--
John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200803101700.m2AH06RT026748>