Date: Tue, 27 Jul 1999 21:21:26 -0700 From: "David O'Brien" <obrien@NUXI.com> To: Warner Losh <imp@village.org> Cc: hackers@FreeBSD.ORG Subject: Re: newsyslog owner.group -> owner:group Message-ID: <19990727212126.E66569@dragon.nuxi.com> In-Reply-To: <199907280340.VAA68413@harmony.village.org>; from Warner Losh on Tue, Jul 27, 1999 at 09:40:34PM -0600 References: <19755.933088309@axl.noc.iafrica.com> <199907280340.VAA68413@harmony.village.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> A better patch would check to see if the text to the right of the '.'
> is a valid group... However, the above will still parse
>
> fred.jones:fred.jones
>
> in the most desirable way, so I suppose the validity checking is
> overkill.
This is what I plan to commit (w/in minutes):
- if ((group = strchr(q, ':')) != NULL) {
+ if ((group = strchr(q, ':')) != NULL ||
+ (group = strrchr(q, '.')) != NULL) {
It the becomes [almost totally] non-ambigitous (since the separator is
required) and allows "david.obrien.staff". In my mind more people use
dots in usernames than group names. Anyay, it is documented to use :,
and I am just trying to be "liberal in what is accepted" (w/o
obfuscating the code).
--
-- David (obrien@NUXI.com -or- obrien@FreeBSD.org)
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19990727212126.E66569>