Date: Tue, 30 May 2017 20:03:54 +0000 From: Rick Macklem <rmacklem@uoguelph.ca> To: Konstantin Belousov <kostikbel@gmail.com>, John Baldwin <jhb@freebsd.org> Cc: "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r318997 - in head/sys: cddl/contrib/opensolaris/uts/common/fs/zfs fs/nfsclient kern sys Message-ID: <YTXPR01MB0189B85A92C9CF5F6183E61EDDF00@YTXPR01MB0189.CANPRD01.PROD.OUTLOOK.COM> In-Reply-To: <20170530171904.GL82323@kib.kiev.ua> References: <201705271700.v4RH0USD004310@repo.freebsd.org> <2187407.D9lHvpEUce@ralph.baldwin.cx>,<20170530171904.GL82323@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
Konstantin Belousov wrote: >Thank you. >Indeed, the asignment should have been removed. Below is the proposed >correction. > >diff --git a/sys/fs/nfsclient/nfs_clport.c b/sys/fs/nfsclient/nfs_clport.c >index 509c38b8614..44c0eae0179 100644 >--- a/sys/fs/nfsclient/nfs_clport.c >+++ b/sys/fs/nfsclient/nfs_clport.c >@@ -491,8 +491,7 @@ nfscl_loadattrcache(struct vnode **vpp, struct nfsvatt= r *nap, void > *nvaper, > * in the mounted subtree. > */ > vn_fsid(vp, vap); > - vap->va_fsid =3D np->n_vattr.na_filesid[0]; > - if (vap->va_fsid =3D=3D np->n_vattr.na_filesid[0]) > + if ((uint32_t)vap->va_fsid =3D=3D np->n_vattr.na_filesid[= 0]) > vap->va_fsid =3D hash32_buf( > np->n_vattr.na_filesid, 2 * sizeof(uint64_t), = 0); > } else Yep. Yhis revised one looks fine to me, rick
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YTXPR01MB0189B85A92C9CF5F6183E61EDDF00>