Date: Sun, 19 Sep 2004 19:28:52 -0700 From: Brooks Davis <brooks@one-eyed-alien.net> To: Max Laier <max@love2party.net> Cc: freebsd-arch@freebsd.org Subject: Re: Global (non _KERNEL) place for sockaddr_union? Message-ID: <20040920022852.GA21281@odin.ac.hmc.edu> In-Reply-To: <200409200250.49518.max@love2party.net> References: <200409200250.49518.max@love2party.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 20, 2004 at 02:50:40AM +0200, Max Laier wrote: > Hi, >=20 > http://www.freebsd.org/cgi/query-pr.cgi?pr=3Dkern/71836 is the symptom. N= ow I am=20 > looking for a clean solution to it. What is needed is an include file tha= t=20 > defines union sockaddr_union in a way that is useable from kernel and=20 > userland. Historically it seems that this union first apeared in context = of=20 > ipsec within the kernel. pf has adopted it, but uses it in the userland a= s=20 > well. I am sure that it can be usefull in a lot of places that have to de= al=20 > with/store different address formats. >=20 > My question now is, what would be a good place to define this? Are there = any=20 > fromal standarts that might define it already? (Couldn't find anything) I= s=20 > there anything else that I must consider? >=20 > At some point I though netinet/in.h might be a good place, but that'd req= uire=20 > inclusion of sys/socket.h, which certainly is not a good solution. >=20 > Opinions? Ideas? >=20 > > #include <sys/socket.h> > > #include <netinet/in.h> > >=20 > > union sockaddr_union { > > struct sockaddr sa; > > struct sockaddr_in sin; > > struct sockaddr_in6 sin6; > > struct sockaddr_storage __su_pad; /* maybe not a bad idea */ > > }; I don't see an elegant solution. Stuffing it off in its own file may be the best thing if you're going to use it. Overall, I'd say it's bad idea that PF be better off without. It appears to save a few casts, but nothing worth the pain of generalizing the declaration. -- Brooks --=20 Any statement of the form "X is the one, true Y" is FALSE. PGP fingerprint 655D 519C 26A7 82E7 2529 9BF0 5D8E 8BE9 F238 1AD4 --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQFBTkBkXY6L6fI4GtQRAkN5AJ4vSbihrYfqgTxU4MrgF4vNXFYr6ACeJ0Uh aeCoFMPqPGpWIYLi5DDzc4c= =WKvT -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040920022852.GA21281>