Date: Fri, 29 Apr 2005 19:28:51 +0200 From: Juergen Lock <nox@jelal.kn-bremen.de> To: Jung-uk Kim <jkim@niksun.com> Cc: freebsd-amd64@freebsd.org Subject: Re: please test qemu port update Message-ID: <20050429192851.A47512@saturn.kn-bremen.de> In-Reply-To: <200504290313.18498.jkim@niksun.com> References: <20050427210405.A95072@saturn.kn-bremen.de> <20050428210246.A21966@saturn.kn-bremen.de> <200504281514.01411.jkim@niksun.com> <200504290313.18498.jkim@niksun.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Apr 29, 2005 at 03:13:15AM -0400, Jung-uk Kim wrote:
> On Thursday 28 April 2005 03:14 pm, Jung-uk Kim wrote:
> > On Thursday 28 April 2005 03:02 pm, Juergen Lock wrote:
>[...]
> > > Or is this a difference between i386 and amd64?
> >
> > I believe Makefile.target is doing something wrong but I haven't
> > found it yet. I believe the culprit is Makefile.target not
> > checking ARCH == amd64 but x86_64. In fact, it works perfect for
> > i386.
>
> Yup, that's it. MAKE_ENV was overriding ARCH==x86_64 in QEMU's
> makefiles.
>
Yeah looks like after .if !defined(NOPRECIOUSMAKEVARS) in
/usr/ports/Mk/bsd.port.mk...
> > > And if it really is, I would prefer setting the right variables
> > > (like USE_GMAKE, see /usr/ports/Mk/bsd.port.mk) instead of simply
> > > overriding the do-* targets.
> >
> > I'd love to find it out. I will let you know when I get that
> > right.
>
> The final patch (I hope) is attached. This version includes few minor
> fixes too.
>
> I think it is commitable now.
I found one small bug,
Index: Makefile
@@ -39,6 +39,8 @@
BUILD_DEPENDS+= gcc34:${PORTSDIR}/lang/gcc34
GCCVERSION= 030402
CC= gcc34
+.else
+USE_GCC= 3.4
.endif
.else
USE_GCC= 3.4
(tho it probably doesnt matter as i doubt there's an amd64 branch
that uses an older gcc than 3.4...)
Any commiters here, or should i still send-pr?
Juergen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050429192851.A47512>