Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 15 Jun 2010 11:49:39 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        David Schultz <das@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r209110 - in head/lib/msun: . src
Message-ID:  <20100615084939.GL13238@deviant.kiev.zoral.com.ua>
In-Reply-To: <201006121732.o5CHW5Cs065722@svn.freebsd.org>
References:  <201006121732.o5CHW5Cs065722@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--HcLgruZUVNEEX12n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 12, 2010 at 05:32:05PM +0000, David Schultz wrote:
> Author: das
> Date: Sat Jun 12 17:32:05 2010
> New Revision: 209110
> URL: http://svn.freebsd.org/changeset/base/209110
>=20
> Log:
>   Introduce __isnanf() as an alias for isnanf(), and make the isnan()
>   macro expand to __isnanf() instead of isnanf() for float arguments.
>   This change is needed because isnanf() isn't declared in strict POSIX
>   or C99 mode.
>  =20
>   Compatibility note: Apps using isnan(float) that are compiled after
>   this change won't link against an older libm.
>  =20
>   Reported by:	Florian Forster <octo@verplant.org>

May be, it makes sense to remove the default version for the isnan symbol ?

diff --git a/lib/msun/Symbol.map b/lib/msun/Symbol.map
index 429a76f..e39b39f 100644
--- a/lib/msun/Symbol.map
+++ b/lib/msun/Symbol.map
@@ -118,7 +118,6 @@ FBSD_1.0 {
 	__isfinite;
 	__isfinitef;
 	__isfinitel;
-	isnanf;
 	__isnanl;
 	__isnormal;
 	__isnormalf;
diff --git a/lib/msun/src/s_isnan.c b/lib/msun/src/s_isnan.c
index 0f544db..1fdbe96 100644
--- a/lib/msun/src/s_isnan.c
+++ b/lib/msun/src/s_isnan.c
@@ -61,4 +61,4 @@ __isnanl(long double e)
 	return (u.bits.exp =3D=3D 32767 && (u.bits.manl !=3D 0 || u.bits.manh !=
=3D 0));
 }
=20
-__weak_reference(__isnanf, isnanf);
+__sym_compat(isnanf, __isnanf, FBSD_1.0);

--HcLgruZUVNEEX12n
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (FreeBSD)

iEYEARECAAYFAkwXPqMACgkQC3+MBN1Mb4hkfgCdEXPrzD/WPEV0tjpIdYOIy7Tw
iRQAn0QKK9aMZFg9i0JyHs+bwkJn7cn1
=okqS
-----END PGP SIGNATURE-----

--HcLgruZUVNEEX12n--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100615084939.GL13238>