Date: Mon, 1 Dec 2014 08:13:07 -0800 From: Jack Vogel <jfvogel@gmail.com> To: Alfred Perlstein <bright@mu.org> Cc: Hans Petter Selasky <hps@selasky.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, John Baldwin <jhb@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, Alfred Perlstein <alfred@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r275136 - in head/sys: dev/e1000 dev/ixgbe kern sys Message-ID: <CAFOYbcmQuc1__atKJcBZfN3OFVVJhKuKKvcH9pBjQX43qjfMVQ@mail.gmail.com> In-Reply-To: <92F537D5-E1C8-402E-9EDC-CB6270059BCA@mu.org> References: <201411262019.sAQKJaw4043557@svn.freebsd.org> <39377603.10OyiSzjWY@ralph.baldwin.cx> <872C180A-6ADD-469F-A801-3728DF134EEC@mu.org> <547C88A9.1070007@selasky.org> <5E1B6CD4-BBA7-4AD0-9982-E981015AF138@mu.org> <547C8A9C.4080603@selasky.org> <F621EBD1-C330-456A-B130-A2F46B5F8355@mu.org> <547C8CA2.8040305@selasky.org> <EB6CB885-C5B2-4D7C-A502-18A4E8F5EF40@mu.org> <547C8DEF.5020809@selasky.org> <EA71D8ED-A7C6-4570-B889-30C741EA1E0F@mu.org> <CAFOYbcnKAwT6fZH53mQamuVyFEo4P2xUbNLcyaF6YsM2U9-0%2Bg@mail.gmail.com> <92F537D5-E1C8-402E-9EDC-CB6270059BCA@mu.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Really, and did I say that I approved, because I do not recall the event? Jack On Mon, Dec 1, 2014 at 8:08 AM, Alfred Perlstein <bright@mu.org> wrote: > Jack you were asked. Please see the review system. > > Sent from my iPhone > > On Dec 1, 2014, at 8:05 AM, Jack Vogel <jfvogel@gmail.com> wrote: > > There is no mystery about who's drivers these are, and its not like it > would > take a lot of effort to figure out ownership and ask us for review. > > Remove this commit until I have had time to look it over! > > Jack > > > On Mon, Dec 1, 2014 at 7:56 AM, Alfred Perlstein <bright@mu.org> wrote: > >> >> >> > On Dec 1, 2014, at 7:49 AM, Hans Petter Selasky <hps@selasky.org> >> wrote: >> > >> >> On 12/01/14 16:45, Alfred Perlstein wrote: >> >> >> >> > Hi, >> >>> >> >>> It is quite early, actually: >> >>> >> >>> SYSINIT(sysctl, SI_SUB_KMEM, SI_ORDER_FIRST, sysctl_register_all, 0); >> >>> >> >>> In some parts of the machine independent, MI, code you neee to keep >> the TUNABLE_FETCH'es, because its run before SI_SUB_KMEM ! >> >> >> >> Then it will not work unless I move the global n_queues sysctl >> creation into the driver's mod load function. >> >> >> >> Is that ok? >> > >> > Are you asking me? >> >> In soviet russia no one is ever sure whom to ask for permission to >> proceed. >> >> (Also you have significant commits to the driver so it makes sense. ) >> >> >> > >> > --HPS >> > >> > >> >> >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFOYbcmQuc1__atKJcBZfN3OFVVJhKuKKvcH9pBjQX43qjfMVQ>