Date: Mon, 15 Apr 2002 10:37:54 -0400 From: Coleman Kane <cokane@FreeBSD.org> To: Frank Mayhar <frank@exit.com> Cc: hackers@freebsd.org Subject: Re: Minor weirdness in pci/agp_amd.c. Message-ID: <20020415103754.A18397@freebsd.org> In-Reply-To: <200204142357.g3ENvHFT091843@realtime.exit.com> References: <200204142357.g3ENvHFT091843@realtime.exit.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This was the case in older revisions, it has been fixed in RELENG_4 and -CURRENT. The driver shipped with 4.5-RELEASE was broken. -- coleman On Sun, Apr 14, 2002 at 04:57:17PM -0700, Frank Mayhar wrote: > I'm working on writing a driver for the ServerWorks AGP support from the > Linux driver (sans documentation, SIGH :-(). I've been using the various > other drivers as models, particularly the AMD driver, since it seems to be > closest in many ways to the ServerWorks architecture. > > Anyway, I've run into a minor oddity in agp_amd_alloc_gatt(), in pci/agp_amd.c. > At lines 120-121: > gatt->ag_pdir = vtophys((vm_offset_t) gatt->ag_vdir); > gatt->ag_pdir = vtophys(gatt->ag_virtual); > > Looks like one or the other is redundant? Probably the first, I would guess, > if the code actually works as it is. > -- > Frank Mayhar frank@exit.com http://www.exit.com/ > Exit Consulting http://www.gpsclock.com/ > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-hackers" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020415103754.A18397>